Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/android/chrome_feature_list.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: extract deletion logic to util class Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/chrome_feature_list.h" 5 #include "chrome/browser/android/chrome_feature_list.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 namespace { 31 namespace {
32 32
33 // Array of features exposed through the Java ChromeFeatureList API. Entries in 33 // Array of features exposed through the Java ChromeFeatureList API. Entries in
34 // this array may either refer to features defined in the header of this file or 34 // this array may either refer to features defined in the header of this file or
35 // in other locations in the code base (e.g. chrome/, components/, etc). 35 // in other locations in the code base (e.g. chrome/, components/, etc).
36 const base::Feature* kFeaturesExposedToJava[] = { 36 const base::Feature* kFeaturesExposedToJava[] = {
37 &autofill::kAutofillScanCardholderName, 37 &autofill::kAutofillScanCardholderName,
38 &features::kConsistentOmniboxGeolocation, 38 &features::kConsistentOmniboxGeolocation,
39 &features::kCredentialManagementAPI, 39 &features::kCredentialManagementAPI,
40 &features::kImportantSitesInCBD,
40 &features::kNativeAndroidHistoryManager, 41 &features::kNativeAndroidHistoryManager,
41 &features::kServiceWorkerPaymentApps, 42 &features::kServiceWorkerPaymentApps,
42 &features::kSimplifiedFullscreenUI, 43 &features::kSimplifiedFullscreenUI,
43 &features::kVrShell, 44 &features::kVrShell,
44 &features::kWebPayments, 45 &features::kWebPayments,
45 &kAndroidPayIntegrationV1, 46 &kAndroidPayIntegrationV1,
46 &kAndroidPayIntegrationV2, 47 &kAndroidPayIntegrationV2,
47 &kAndroidPaymentApps, 48 &kAndroidPaymentApps,
48 &kCCTExternalLinkHandling, 49 &kCCTExternalLinkHandling,
49 &kCCTPostMessageAPI, 50 &kCCTPostMessageAPI,
50 &kChromeHomeFeature, 51 &kChromeHomeFeature,
51 &kContextualSearchSingleActions, 52 &kContextualSearchSingleActions,
52 &kContextualSearchUrlActions, 53 &kContextualSearchUrlActions,
53 &kCustomFeedbackUi, 54 &kCustomFeedbackUi,
54 &kImportantSitesInCBD,
55 &kImprovedA2HS, 55 &kImprovedA2HS,
56 &kNoCreditCardAbort, 56 &kNoCreditCardAbort,
57 &kNTPCondensedLayoutFeature, 57 &kNTPCondensedLayoutFeature,
58 &kNTPCondensedTileLayoutFeature, 58 &kNTPCondensedTileLayoutFeature,
59 &kNTPFakeOmniboxTextFeature, 59 &kNTPFakeOmniboxTextFeature,
60 &kNTPLaunchAfterInactivity, 60 &kNTPLaunchAfterInactivity,
61 &kNTPOfflinePagesFeature, 61 &kNTPOfflinePagesFeature,
62 &NTPShowGoogleGInOmniboxFeature, 62 &NTPShowGoogleGInOmniboxFeature,
63 &kPhysicalWebFeature, 63 &kPhysicalWebFeature,
64 &kPhysicalWebSharing, 64 &kPhysicalWebSharing,
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 const base::Feature kCustomFeedbackUi{"CustomFeedbackUi", 116 const base::Feature kCustomFeedbackUi{"CustomFeedbackUi",
117 base::FEATURE_DISABLED_BY_DEFAULT}; 117 base::FEATURE_DISABLED_BY_DEFAULT};
118 118
119 const base::Feature kDownloadAutoResumptionThrottling{ 119 const base::Feature kDownloadAutoResumptionThrottling{
120 "DownloadAutoResumptionThrottling", base::FEATURE_ENABLED_BY_DEFAULT}; 120 "DownloadAutoResumptionThrottling", base::FEATURE_ENABLED_BY_DEFAULT};
121 121
122 const base::Feature kContextualSearchUrlActions{ 122 const base::Feature kContextualSearchUrlActions{
123 "ContextualSearchUrlActions", base::FEATURE_DISABLED_BY_DEFAULT}; 123 "ContextualSearchUrlActions", base::FEATURE_DISABLED_BY_DEFAULT};
124 124
125 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD",
126 base::FEATURE_DISABLED_BY_DEFAULT};
127
128 // Makes "Add to Home screen" in the app menu generate an APK for the shortcut 125 // Makes "Add to Home screen" in the app menu generate an APK for the shortcut
129 // URL which opens Chrome in fullscreen. 126 // URL which opens Chrome in fullscreen.
130 const base::Feature kImprovedA2HS{"ImprovedA2HS", 127 const base::Feature kImprovedA2HS{"ImprovedA2HS",
131 base::FEATURE_DISABLED_BY_DEFAULT}; 128 base::FEATURE_DISABLED_BY_DEFAULT};
132 129
133 const base::Feature kNoCreditCardAbort{"NoCreditCardAbort", 130 const base::Feature kNoCreditCardAbort{"NoCreditCardAbort",
134 base::FEATURE_DISABLED_BY_DEFAULT}; 131 base::FEATURE_DISABLED_BY_DEFAULT};
135 132
136 const base::Feature kNTPCondensedLayoutFeature{ 133 const base::Feature kNTPCondensedLayoutFeature{
137 "NTPCondensedLayout", base::FEATURE_DISABLED_BY_DEFAULT}; 134 "NTPCondensedLayout", base::FEATURE_DISABLED_BY_DEFAULT};
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name, 236 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name,
240 jdefault_value); 237 jdefault_value);
241 } 238 }
242 239
243 bool RegisterChromeFeatureListJni(JNIEnv* env) { 240 bool RegisterChromeFeatureListJni(JNIEnv* env) {
244 return RegisterNativesImpl(env); 241 return RegisterNativesImpl(env);
245 } 242 }
246 243
247 } // namespace android 244 } // namespace android
248 } // namespace chrome 245 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698