Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 2716273004: Invert description and URL for experimental zero suggest suggestions. (Closed)
Patch Set: Remove unnecessary function. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/features.cc ('k') | components/omnibox/browser/omnibox_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/omnibox_field_trial.h
diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h
index e0edee7a9cef1a66550cbc3692221c45b3783ffb..808ab7c75346e07000d5446bfdf3d39995f57117 100644
--- a/components/omnibox/browser/omnibox_field_trial.h
+++ b/components/omnibox/browser/omnibox_field_trial.h
@@ -14,7 +14,7 @@
#include "base/macros.h"
#include "components/metrics/proto/omnibox_event.pb.h"
-#include "components/metrics/proto/omnibox_input_type.pb.h"
+#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_match_type.h"
namespace base {
@@ -375,11 +375,11 @@ class OmniboxFieldTrial {
// field trial.
// Returns the conditions under which the UI code should display the title
- // of a URL more prominently than the URL for an input of type |input_type|.
- // Normally the URL is displayed more prominently. Returns NEVER_EMPHASIZE
- // if the experiment isn't active.
+ // of a URL more prominently than the URL for input |input|. Normally the URL
+ // is displayed more prominently. Returns NEVER_EMPHASIZE if the experiment
+ // isn't active.
static EmphasizeTitlesCondition GetEmphasizeTitlesConditionForInput(
- metrics::OmniboxInputType::Type input_type);
+ const AutocompleteInput& input);
// ---------------------------------------------------------
// For PhysicalWebProvider related experiments.
@@ -405,8 +405,8 @@ class OmniboxFieldTrial {
// For experiment redirecting zero suggest requests to a service provided by
// the Chrome team.
- // Returns whether the user is in the field trial which redirects zero suggest
- // requests to the service provided by the Chrome team.
+ // Returns true whether the user is in the field trial which redirects zero
+ // suggest requests to the service provided by the Chrome team.
static bool InZeroSuggestRedirectToChromeFieldTrial();
// Returns a string representing the address of the server where the zero
« no previous file with comments | « components/omnibox/browser/features.cc ('k') | components/omnibox/browser/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698