Chromium Code Reviews| Index: components/omnibox/browser/omnibox_field_trial.h |
| diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h |
| index 6c7ca25b0c1faa810425f4f20c9e85d3aa803cf6..adbbea2f34af0ef0f5e785ec7deab838fc5c0fc0 100644 |
| --- a/components/omnibox/browser/omnibox_field_trial.h |
| +++ b/components/omnibox/browser/omnibox_field_trial.h |
| @@ -14,7 +14,7 @@ |
| #include "base/macros.h" |
| #include "components/metrics/proto/omnibox_event.pb.h" |
| -#include "components/metrics/proto/omnibox_input_type.pb.h" |
| +#include "components/omnibox/browser/autocomplete_input.h" |
| #include "components/omnibox/browser/autocomplete_match_type.h" |
| namespace base { |
| @@ -374,11 +374,11 @@ class OmniboxFieldTrial { |
| // field trial. |
| // Returns the conditions under which the UI code should display the title |
| - // of a URL more prominently than the URL for an input of type |input_type|. |
| - // Normally the URL is displayed more prominently. Returns NEVER_EMPHASIZE |
| - // if the experiment isn't active. |
| + // of a URL more prominently than the URL for input |input|. Normally the URL |
| + // is displayed more prominently. Returns NEVER_EMPHASIZE if the experiment |
| + // isn't active. |
| static EmphasizeTitlesCondition GetEmphasizeTitlesConditionForInput( |
| - metrics::OmniboxInputType::Type input_type); |
| + const AutocompleteInput& input); |
| // --------------------------------------------------------- |
| // For PhysicalWebProvider related experiments. |
| @@ -404,8 +404,8 @@ class OmniboxFieldTrial { |
| // For experiment redirecting zero suggest requests to a service provided by |
| // the Chrome team. |
| - // Returns whether the user is in the field trial which redirects zero suggest |
| - // requests to the service provided by the Chrome team. |
| + // Returns true whether the user is in the field trial which redirects zero |
| + // suggest requests to the service provided by the Chrome team. |
| static bool InZeroSuggestRedirectToChromeFieldTrial(); |
| // Returns a string representing the address of the server where the zero |
| @@ -420,6 +420,10 @@ class OmniboxFieldTrial { |
| // request URL. |
| static std::string ZeroSuggestRedirectToChromeAdditionalFields(); |
| + // Returns true whether the user is in the field trial which swaps the title |
| + // and the URL for zero suggest suggestions. |
| + static bool InZeroSuggestSwapTitleAndUrlFieldTrial(); |
|
Mark P
2017/03/01 20:09:25
Please remove this unused function and its impleme
|
| + |
| // --------------------------------------------------------- |
| // Exposed publicly for the sake of unittests. |
| static const char kBundledExperimentFieldTrialName[]; |