components/omnibox/browser/features.h - Issue 2716273004: Invert description and URL for experimental zero suggest suggestions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/omnibox/browser/features.h

Issue 2716273004: Invert description and URL for experimental zero suggest suggestions. (Closed)

Patch Set: Make title/url swap an independent feature Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_OMNIBOX_BROWSER_FEATURES_H_	5 #ifndef COMPONENTS_OMNIBOX_BROWSER_FEATURES_H_

6 #define COMPONENTS_OMNIBOX_BROWSER_FEATURES_H_	6 #define COMPONENTS_OMNIBOX_BROWSER_FEATURES_H_

7	7

8 #include "base/feature_list.h"	8 #include "base/feature_list.h"

9	9

10 namespace features {	10 namespace features {

11	11

	12 // Feature used for the Zero Suggest Redirect to Chrome Field Trial.
	Mark P 2017/02/28 22:24:28 optional nit: I'm not sure if either of these comm optional nit: I'm not sure if either of these comments add anything useful. Remove? gcomanici 2017/03/01 02:56:27 Done. Show quoted text On 2017/02/28 22:24:28, Mark P wrote: > optional nit: I'm not sure if either of these comments add anything useful. > Remove? Done.
12 extern const base::Feature kZeroSuggestRedirectToChrome;	13 extern const base::Feature kZeroSuggestRedirectToChrome;

13	14

	15 // Feature used to swap the title and URL when providing zero suggest

	16 // suggestions.

	17 extern const base::Feature kZeroSuggestSwapTitleAndUrl;

	18

14 } // namespace features	19 } // namespace features

15	20

16 #endif // COMPONENTS_OMNIBOX_BROWSER_FEATURES_H_	21 #endif // COMPONENTS_OMNIBOX_BROWSER_FEATURES_H_

OLD	NEW