Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 271623003: Added localized string for "Manage" button. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Added localized string for "Manage" button. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270060

Patch Set 1 #

Patch Set 2 : Mon 05/12/2014 23:34:15.86 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-12 22:31:24 UTC) #1
Noam Samuel
Wow.Can't believe I missed that one. LGTM.
6 years, 7 months ago (2014-05-12 22:37:42 UTC) #2
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 7 months ago (2014-05-12 22:37:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/271623003/1
6 years, 7 months ago (2014-05-12 22:38:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 03:00:31 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/local_discovery/local_discovery.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-13 03:00:32 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-13 06:35:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/271623003/20001
6 years, 7 months ago (2014-05-13 06:35:23 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 09:34:14 UTC) #9
Message was sent while issue was closed.
Change committed as 270060

Powered by Google App Engine
This is Rietveld 408576698