Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2716133002: Revert "Add error for mixins defining conflicting private names (issue 28809)" (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add error for mixins defining conflicting private names (issue 28809)" Committed: https://github.com/dart-lang/sdk/commit/44148ec0a43bce82f0152b7fea4006c2f179a75e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -176 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +0 lines, -75 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +0 lines, -89 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Brian Wilkerson
This caused a bot failure, but I don't understand the nature of the failure so ...
3 years, 10 months ago (2017-02-25 15:50:31 UTC) #2
Brian Wilkerson
3 years, 10 months ago (2017-02-25 15:50:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44148ec0a43bce82f0152b7fea4006c2f179a75e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698