Issue 271613004: A speculative fix for a MediaValues related crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271613004: A speculative fix for a MediaValues related crash (Closed)

Created:
6 years, 7 months ago by Yoav Weiss

Modified:
6 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

A speculative fix for a MediaValues related crash According to the stack at crbug.com/367210 it is believed that the crash is a result of null RenderView, since a plugin is running a script that adds a new HTMLImageElement during the document teardown. This CL adds a null check for such a case, as well as a fixme, so that null check can be removed once the underlying issue is resolved. BUG=367210, 371084 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173563

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/core/css/MediaValuesCached.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/271613004/1

6 years, 7 months ago (2014-05-07 20:51:22 UTC) #5

Message was sent while issue was closed.

Change committed as 173563

Expand Messages | Collapse Messages