Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 271613002: gn: simplify generated extensions API template. (Closed)

Created:
6 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

gn: simplify generated extensions API template. This simplifies the template a bit by removing the (now implied) hard_dep values and using the new get_target_outputs function in lieu of process_file_template. BUG=None TBR=yoz Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M extensions/generated_extensions_api.gni View 3 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ken Rockot(use gerrit already)
ptal
6 years, 7 months ago (2014-05-07 05:51:31 UTC) #1
brettw
nice, lgtm
6 years, 7 months ago (2014-05-07 17:30:38 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-07 18:03:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/271613002/1
6 years, 7 months ago (2014-05-07 18:08:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 21:51:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 01:17:40 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 02:50:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 03:22:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium
6 years, 7 months ago (2014-05-08 03:22:46 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-08 16:00:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/271613002/1
6 years, 7 months ago (2014-05-08 16:02:25 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 01:32:13 UTC) #12
Message was sent while issue was closed.
Change committed as 269133

Powered by Google App Engine
This is Rietveld 408576698