[HBD] Add an Enable Flash context menu item for HBD placeholders.

chrome/renderer/plugins/chrome_plugin_placeholder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/plugins/chrome_plugin_placeholder.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/features.h"
 #include "chrome/common/prerender_messages.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/renderer_resources.h"
 #include "chrome/renderer/chrome_content_renderer_client.h"
 #include "chrome/renderer/content_settings_observer.h"
 #include "chrome/renderer/custom_menu_commands.h"
 #include "chrome/renderer/plugins/plugin_preroller.h"
 #include "chrome/renderer/plugins/plugin_uma.h"
 #include "components/strings/grit/components_strings.h"
+#include "components/url_formatter/elide_url.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/context_menu_params.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_thread.h"
 #include "gin/object_template_builder.h"
 #include "third_party/WebKit/public/platform/URLConversion.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
 #include "third_party/WebKit/public/platform/WebMouseEvent.h"
+#include "third_party/WebKit/public/platform/WebSecurityOrigin.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebScriptSource.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/webui/jstemplate_builder.h"
 #include "ui/gfx/geometry/size.h"
 #include "url/origin.h"
 #include "url/url_util.h"
@@ skipping 261 matching lines @@
       MarkPluginEssential(
           content::PluginInstanceThrottler::UNTHROTTLE_METHOD_BY_CLICK);
       LoadPlugin();
       break;
     }
     case chrome::MENU_COMMAND_PLUGIN_HIDE: {
       RenderThread::Get()->RecordAction(UserMetricsAction("Plugin_Hide_Menu"));
       HidePlugin();
       break;
     }
+    case chrome::MENU_COMMAND_ENABLE_FLASH: {
+      ShowPermissionBubbleCallback();
+      break;
+    }
     default:
       NOTREACHED();
   }
 }
 
 void ChromePluginPlaceholder::OnMenuClosed(int request_id) {
   DCHECK_EQ(context_menu_request_id_, request_id);
   context_menu_request_id_ = 0;
 }
 
@@ skipping 12 matching lines @@
   if (!title_.empty()) {
     content::MenuItem name_item;
     name_item.label = title_;
     params.custom_items.push_back(name_item);
 
     content::MenuItem separator_item;
     separator_item.type = content::MenuItem::SEPARATOR;
     params.custom_items.push_back(separator_item);
   }
 
-  if (!GetPluginInfo().path.value().empty()) {
+  bool flash_hidden =
+      status_ == ChromeViewHostMsg_GetPluginInfo_Status::kFlashHiddenPreferHtml;
+  if (!GetPluginInfo().path.value().empty() && !flash_hidden) {
     content::MenuItem run_item;
     run_item.action = chrome::MENU_COMMAND_PLUGIN_RUN;
     // Disable this menu item if the plugin is blocked by policy.
     run_item.enabled = LoadingAllowed();
     run_item.label = l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLUGIN_RUN);
     params.custom_items.push_back(run_item);
   }
 
+  if (flash_hidden) {
+    content::MenuItem enable_flash_item;
+    enable_flash_item.action = chrome::MENU_COMMAND_ENABLE_FLASH;
+    enable_flash_item.enabled = true;
+    base::string16 display_origin = url_formatter::FormatUrlForSecurityDisplay(

[tommycli, 2017/02/24 20:09:02]

Same technique as
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/website_settings...

+        url::Origin(GetFrame()->top()->getSecurityOrigin()).GetURL(),
+        url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC);

[raymes, 2017/02/27 03:51:45]

What's the motivation for displaying the origin here? Is it necessary given that
we will show the origin in the permission prompt?

[tommycli, 2017/02/27 19:15:33]

Hey see https://bugs.chromium.org/p/chromium/issues/detail?id=690304#c9 and
comment 10 also.

Basically -- in the past, "Run this plugin" applied to that plugin instance
only. However, triggering the permission prompt actually enables Flash on the
whole top-level origin, so technically, including the origin in the menu item is
more correct.

However, if you think the permission prompt itself covers that information
adequately, I'm happy to remove this code. It's not a big deal for me either
way. We should probably hash it out on the bug itself.

[raymes, 2017/02/27 22:55:57]

Ahh thanks for explaining.

I actually think it's somewhat confusing if we leave it in because it gives me a
sense that the flash instance is being served from the origin that appears in
the dialog, which it isn't necessarily.

Given that there is confusion anyway I would suggest leaving it out. 

+    enable_flash_item.label = l10n_util::GetStringFUTF16(
+        IDS_CONTENT_CONTEXT_ENABLE_FLASH, display_origin);
+    params.custom_items.push_back(enable_flash_item);
+  }
+
   content::MenuItem hide_item;
   hide_item.action = chrome::MENU_COMMAND_PLUGIN_HIDE;
   bool is_main_frame_plugin_document =
       GetFrame()->view()->mainFrame()->isWebLocalFrame() &&
       GetFrame()->view()->mainFrame()->document().isPluginDocument();
   hide_item.enabled = !is_main_frame_plugin_document;
   hide_item.label = l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLUGIN_HIDE);
   params.custom_items.push_back(hide_item);
 
   params.x = event.windowX;
@@ skipping 46 matching lines @@
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnablePluginPlaceholderTesting)) {
     builder.SetMethod<void (ChromePluginPlaceholder::*)()>(
         "didFinishIconRepositionForTesting",
         &ChromePluginPlaceholder::DidFinishIconRepositionForTestingCallback);
   }
 
   return builder;
 }