Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2716013003: Fixes to enable indication of bytes downloaded for Offline Pages in Download Home. (Closed)
Patch Set: fix build break Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index d7ef68da8e7b52ea94767a452fff64b193746b81..09b3350af0d500af4399013891dabbe511b09e13 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -42,10 +42,6 @@ using base::android::JavaParamRef;
using base::android::ScopedJavaGlobalRef;
using base::android::ScopedJavaLocalRef;
-namespace {
-const char kDownloadUIAdapterKey[] = "download-ui-adapter";
-}
-
namespace offline_pages {
namespace android {
@@ -476,8 +472,8 @@ static jlong Init(JNIEnv* env,
OfflinePageModelFactory::GetForBrowserContext(browser_context);
DCHECK(offline_page_model);
- DownloadUIAdapter* adapter = static_cast<DownloadUIAdapter*>(
- offline_page_model->GetUserData(kDownloadUIAdapterKey));
+ DownloadUIAdapter* adapter =
+ DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
if (!adapter) {
RequestCoordinator* request_coordinator =
@@ -486,7 +482,7 @@ static jlong Init(JNIEnv* env,
adapter = new DownloadUIAdapter(
offline_page_model, request_coordinator,
base::MakeUnique<DownloadUIAdapterDelegate>(offline_page_model));
- offline_page_model->SetUserData(kDownloadUIAdapterKey, adapter);
+ DownloadUIAdapter::AttachToOfflinePageModel(adapter, offline_page_model);
}
return reinterpret_cast<jlong>(

Powered by Google App Engine
This is Rietveld 408576698