Chromium Code Reviews| Index: components/offline_pages/core/downloads/download_ui_adapter.cc |
| diff --git a/components/offline_pages/core/downloads/download_ui_adapter.cc b/components/offline_pages/core/downloads/download_ui_adapter.cc |
| index d73ed686aa5e8b2a72f52bde5354e0da75e98e80..4d3c2a034a03df460d989e68b5a680907b26cb36 100644 |
| --- a/components/offline_pages/core/downloads/download_ui_adapter.cc |
| +++ b/components/offline_pages/core/downloads/download_ui_adapter.cc |
| @@ -16,8 +16,26 @@ |
| #include "components/offline_pages/core/downloads/download_ui_item.h" |
| #include "components/offline_pages/core/offline_page_model.h" |
| +namespace { |
| +// Value of this constant doesn't matter, only its address is used. |
|
fgorski
2017/02/27 16:22:55
Are you not worried that compiler might optimize t
Dmitry Titov
2017/02/27 20:02:17
Shouldn't since the address of this is passed and
|
| +const char kDownloadUIAdapterKey[] = ""; |
| +} |
| + |
| namespace offline_pages { |
| +// static |
| +DownloadUIAdapter* DownloadUIAdapter::FromOfflinePageModel( |
| + OfflinePageModel* model) { |
|
fgorski
2017/02/27 16:22:55
dcheck(model); please
Dmitry Titov
2017/02/27 20:02:17
Done.
|
| + return static_cast<DownloadUIAdapter*>( |
| + model->GetUserData(kDownloadUIAdapterKey)); |
| +} |
| + |
| +// static |
| +void DownloadUIAdapter::AttachToOfflinePageModel(DownloadUIAdapter* adapter, |
| + OfflinePageModel* model) { |
|
fgorski
2017/02/27 16:22:55
dcheck both please.
Dmitry Titov
2017/02/27 20:02:17
Done.
|
| + model->SetUserData(kDownloadUIAdapterKey, adapter); |
| +} |
| + |
| DownloadUIAdapter::ItemInfo::ItemInfo(const OfflinePageItem& page) |
| : ui_item(base::MakeUnique<DownloadUIItem>(page)), |
| is_request(false), |