Index: cc/output/renderer_pixeltest.cc |
diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc |
index 63f55e47641a64359b5a4ecad8deb9530078aa86..38ad62264d115e266b2053981dec231e8b337098 100644 |
--- a/cc/output/renderer_pixeltest.cc |
+++ b/cc/output/renderer_pixeltest.cc |
@@ -2634,6 +2634,12 @@ bool IsSoftwareRenderer<SoftwareRendererWithExpandedViewport>() { |
return true; |
} |
+void draw_point_color(SkCanvas* canvas, SkScalar x, SkScalar y, SkColor color) { |
+ SkPaint paint; |
+ paint.setColor(color); |
+ canvas->drawPoint(x, y, paint); |
+} |
+ |
// If we disable image filtering, then a 2x2 bitmap should appear as four |
// huge sharp squares. |
TYPED_TEST(SoftwareRendererPixelTest, PictureDrawQuadDisableImageFiltering) { |
@@ -2654,10 +2660,10 @@ TYPED_TEST(SoftwareRendererPixelTest, PictureDrawQuadDisableImageFiltering) { |
sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(2, 2); |
ASSERT_NE(surface, nullptr); |
SkCanvas* canvas = surface->getCanvas(); |
- canvas->drawPoint(0, 0, SK_ColorGREEN); |
- canvas->drawPoint(0, 1, SK_ColorBLUE); |
- canvas->drawPoint(1, 0, SK_ColorBLUE); |
- canvas->drawPoint(1, 1, SK_ColorGREEN); |
+ draw_point_color(canvas, 0, 0, SK_ColorGREEN); |
+ draw_point_color(canvas, 0, 1, SK_ColorBLUE); |
+ draw_point_color(canvas, 1, 0, SK_ColorBLUE); |
+ draw_point_color(canvas, 1, 1, SK_ColorGREEN); |
std::unique_ptr<FakeRecordingSource> recording = |
FakeRecordingSource::CreateFilledRecordingSource(viewport.size()); |
@@ -2703,10 +2709,10 @@ TYPED_TEST(SoftwareRendererPixelTest, PictureDrawQuadNearestNeighbor) { |
sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(2, 2); |
ASSERT_NE(surface, nullptr); |
SkCanvas* canvas = surface->getCanvas(); |
- canvas->drawPoint(0, 0, SK_ColorGREEN); |
- canvas->drawPoint(0, 1, SK_ColorBLUE); |
- canvas->drawPoint(1, 0, SK_ColorBLUE); |
- canvas->drawPoint(1, 1, SK_ColorGREEN); |
+ draw_point_color(canvas, 0, 0, SK_ColorGREEN); |
+ draw_point_color(canvas, 0, 1, SK_ColorBLUE); |
+ draw_point_color(canvas, 1, 0, SK_ColorBLUE); |
+ draw_point_color(canvas, 1, 1, SK_ColorGREEN); |
std::unique_ptr<FakeRecordingSource> recording = |
FakeRecordingSource::CreateFilledRecordingSource(viewport.size()); |
@@ -2747,10 +2753,10 @@ TYPED_TEST(RendererPixelTest, TileDrawQuadNearestNeighbor) { |
{ |
SkAutoLockPixels lock(bitmap); |
SkCanvas canvas(bitmap); |
- canvas.drawPoint(0, 0, SK_ColorGREEN); |
- canvas.drawPoint(0, 1, SK_ColorBLUE); |
- canvas.drawPoint(1, 0, SK_ColorBLUE); |
- canvas.drawPoint(1, 1, SK_ColorGREEN); |
+ draw_point_color(&canvas, 0, 0, SK_ColorGREEN); |
+ draw_point_color(&canvas, 0, 1, SK_ColorBLUE); |
+ draw_point_color(&canvas, 1, 0, SK_ColorBLUE); |
+ draw_point_color(&canvas, 1, 1, SK_ColorGREEN); |
} |
gfx::Size tile_size(2, 2); |
@@ -2798,10 +2804,10 @@ TYPED_TEST(SoftwareRendererPixelTest, TextureDrawQuadNearestNeighbor) { |
{ |
SkAutoLockPixels lock(bitmap); |
SkCanvas canvas(bitmap); |
- canvas.drawPoint(0, 0, SK_ColorGREEN); |
- canvas.drawPoint(0, 1, SK_ColorBLUE); |
- canvas.drawPoint(1, 0, SK_ColorBLUE); |
- canvas.drawPoint(1, 1, SK_ColorGREEN); |
+ draw_point_color(&canvas, 0, 0, SK_ColorGREEN); |
+ draw_point_color(&canvas, 0, 1, SK_ColorBLUE); |
+ draw_point_color(&canvas, 1, 0, SK_ColorBLUE); |
+ draw_point_color(&canvas, 1, 1, SK_ColorGREEN); |
} |
gfx::Size tile_size(2, 2); |
@@ -2850,10 +2856,10 @@ TYPED_TEST(SoftwareRendererPixelTest, TextureDrawQuadLinear) { |
{ |
SkAutoLockPixels lock(bitmap); |
SkCanvas canvas(bitmap); |
- canvas.drawPoint(0, 0, SK_ColorGREEN); |
- canvas.drawPoint(0, 1, SK_ColorBLUE); |
- canvas.drawPoint(1, 0, SK_ColorBLUE); |
- canvas.drawPoint(1, 1, SK_ColorGREEN); |
+ draw_point_color(&canvas, 0, 0, SK_ColorGREEN); |
+ draw_point_color(&canvas, 0, 1, SK_ColorBLUE); |
+ draw_point_color(&canvas, 1, 0, SK_ColorBLUE); |
+ draw_point_color(&canvas, 1, 1, SK_ColorGREEN); |
} |
gfx::Size tile_size(2, 2); |