Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2715933004: MD Settings/Options: add equivalent logs for "time until interactive" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/options/options.js ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-ui' implements the UI for the Settings page. 7 * 'settings-ui' implements the UI for the Settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 // </if> 151 // </if>
152 }; 152 };
153 } 153 }
154 154
155 this.showAndroidApps_ = loadTimeData.valueExists('androidAppsAllowed') && 155 this.showAndroidApps_ = loadTimeData.valueExists('androidAppsAllowed') &&
156 loadTimeData.getBoolean('androidAppsAllowed'); 156 loadTimeData.getBoolean('androidAppsAllowed');
157 }, 157 },
158 158
159 /** @override */ 159 /** @override */
160 attached: function() { 160 attached: function() {
161 setTimeout(function() {
162 chrome.send(
163 'metricsHandler:recordTime',
164 ['Settings.TimeUntilInteractive', window.performance.now()]);
dpapad 2017/02/25 01:04:08 How do we differentiate between old VS new timings
Dan Beam 2017/03/04 02:36:05 i really don't care, to be honest. in the case of
dpapad 2017/03/04 02:54:05 SGTM. I did not know we can filter by URL.
165 });
161 // Preload bold Roboto so it doesn't load and flicker the first time used. 166 // Preload bold Roboto so it doesn't load and flicker the first time used.
162 document.fonts.load('bold 12px Roboto'); 167 document.fonts.load('bold 12px Roboto');
163 settings.setGlobalScrollTarget(this.$.headerPanel.scroller); 168 settings.setGlobalScrollTarget(this.$.headerPanel.scroller);
164 }, 169 },
165 170
166 /** @override */ 171 /** @override */
167 detached: function() { 172 detached: function() {
168 settings.resetRouteForTesting(); 173 settings.resetRouteForTesting();
169 }, 174 },
170 175
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 onMenuButtonTap_: function() { 238 onMenuButtonTap_: function() {
234 this.$.drawer.toggle(); 239 this.$.drawer.toggle();
235 }, 240 },
236 241
237 /** @private */ 242 /** @private */
238 directionDelegateChanged_: function() { 243 directionDelegateChanged_: function() {
239 this.$.drawer.align = this.directionDelegate.isRtl() ? 244 this.$.drawer.align = this.directionDelegate.isRtl() ?
240 'right' : 'left'; 245 'right' : 'left';
241 }, 246 },
242 }); 247 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/options.js ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698