Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3184)

Unified Diff: chrome/browser/site_details_browsertest.cc

Issue 2715933002: TEST: Removing PlatformAppsNotIsolated
Patch Set: Modifying the test instead of deleting it. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/site_details_browsertest.cc
diff --git a/chrome/browser/site_details_browsertest.cc b/chrome/browser/site_details_browsertest.cc
index c5b1cf1f770dab0ec1290e0ba86e74a825e3e330..6a9465ce07f1bfc6e36de728abd32d006d7334ef 100644
--- a/chrome/browser/site_details_browsertest.cc
+++ b/chrome/browser/site_details_browsertest.cc
@@ -242,9 +242,10 @@ class SiteDetailsBrowserTest : public ExtensionBrowserTest {
return extension;
}
- // Creates a V2 platform app that loads a web iframe in the app's sandbox
- // page.
- // TODO(lazyboy): Deprecate this behavior in https://crbug.com/615585.
+ // Creates a V2 platform app that tries to loads a web iframe in the app's
+ // sandbox page. Starting in version 57, Chrome will no longer allow external
+ // web content inside sandboxed pages. So the iframe is expected to be
+ // blocked.
void CreateAppWithSandboxPage(const std::string& name) {
std::unique_ptr<TestExtensionDir> dir(new TestExtensionDir);
@@ -940,13 +941,13 @@ IN_PROC_BROWSER_TEST_F(SiteDetailsBrowserTest, MAYBE_IsolateExtensions) {
EXPECT_TRUE(IsInTrial("SiteIsolationExtensionsActive"));
}
-// Due to http://crbug.com/612711, we are not isolating iframes from platform
-// apps with --isolate-extenions.
-IN_PROC_BROWSER_TEST_F(SiteDetailsBrowserTest, PlatformAppsNotIsolated) {
- // --site-per-process will still isolate iframes from platform apps, so skip
- // the test in that case.
- if (content::AreAllSitesIsolatedForTesting())
- return;
+// Creates a V2 platform app that tries to loads a web iframe in the app's
+// sandbox page. Starting in version 57, Chrome will no longer allow external
+// web content inside sandboxed pages. So the iframe is expected to be
+// blocked. If an error page is displayed, it shouldn't be loaded inside a
+// different process.
+IN_PROC_BROWSER_TEST_F(SiteDetailsBrowserTest,
+ PlatformAppsErrorPagesArentOOPIF) {
CreateAppWithSandboxPage("Extension One");
scoped_refptr<TestMemoryDetails> details = new TestMemoryDetails();
details->StartFetchAndWait();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698