Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 271593009: Rewrite AcceptTouchEvents test from content_browsertests to browser_tests. (Closed)

Created:
6 years, 7 months ago by lazyboy
Modified:
6 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rewrite AcceptTouchEvents test from content_browsertests to browser_tests. Ran in trybot to make sure this is not flaky, 200 runs were successful on win and linux trybots. BUG=368077 Test=None, internal test only change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269830

Patch Set 1 #

Patch Set 2 : another upload #

Patch Set 3 : tidy up for review and test bot run #

Patch Set 4 : sync again #

Patch Set 5 : remove repeat macro + remove content_browsertests #

Messages

Total messages: 10 (0 generated)
lazyboy
6 years, 7 months ago (2014-05-12 05:31:57 UTC) #1
Fady Samuel
Awesome! Thanks! LGTM
6 years, 7 months ago (2014-05-12 10:18:51 UTC) #2
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-05-12 15:41:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/271593009/80001
6 years, 7 months ago (2014-05-12 15:42:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 17:33:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 18:03:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/153003)
6 years, 7 months ago (2014-05-12 18:03:37 UTC) #7
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-05-12 18:13:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/271593009/80001
6 years, 7 months ago (2014-05-12 18:14:48 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 18:55:14 UTC) #10
Message was sent while issue was closed.
Change committed as 269830

Powered by Google App Engine
This is Rietveld 408576698