Moved main frame resize to happen outside refreshPageScaleFactor.

Moved main frame resize to happen outside refreshPageScaleFactor.

refreshPageScaleFactor only gets called if the page scale constraints are dirty.
This happens when the page changes width but not when the height changes. This
cuased a bug where changing the window height only wouldn't resize the main
frame/outer viewport.

BUG=370218
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173672

[bokan, 2014-05-07 18:57:46]

Alexandre, PTAL. I think we always want to try sizing the main frame after a
layout, not just when the constraints get dirtied.

[aelias_OOO_until_Jul13, 2014-05-07 21:39:12]

I'd prefer to fix it the other way and dirty the constraints when height
changes.  It doesn't come up very often but there are viewport tag things
involving height so this is the right thing to do.

[bokan, 2014-05-07 23:17:25]

Updated. I just dirtied the constraints on WebViewImpl::resize, or should it be 
needsReset(true)?

[aelias_OOO_until_Jul13, 2014-05-07 23:38:21]

Making the constraints dirty is what we want.  (setNeedsReset would reset the
page scale to minimum scale.)

Investigating further, on Android, the constraints would already be dirtied via
updatePageDefinedViewportConstraints().  So the underlying problem here is the
!settings()->viewportEnabled() early out in that function.  Of course, you
really do want to avoid almost all of the functionality there on desktop, so
your current approach is still right.

I'd like to keep the state machine in PageScaleConstraintsSet implicit so I
don't like WebViewImpl telling it explicitly to dirty constraints.  I'd suggest
calling your new method PageScaleConstraintsSet::didChangeViewSize(IntSize). 
(As a cleanup and to make use of the argument, you could also stash away the
size in a new PageScaleConstraintsSet field and remove the size argument from
all the methods where it's currently an argument in that class.)

[bokan, 2014-05-08 17:14:17]

Thanks for clarifying. I've made the changes you suggested. PTAL.

[aelias_OOO_until_Jul13, 2014-05-08 18:21:44]

lgtm

[bokan, 2014-05-08 18:54:51]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-05-08 18:56:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bokan@chromium.org/271593005/60001

[commit-bot: I haz the power, 2014-05-08 20:14:40]

Change committed as 173672