Issue 271593004: Revert of Updates webrtc/libjingle to 6070

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271593004: Revert of Updates webrtc/libjingle to 6070 (Closed)

Created:
6 years, 7 months ago by grt (UTC plus 2)

Modified:
6 years, 7 months ago

Reviewers:
Ronghua Wu (Left Chromium), henrika (OOO until Aug 14)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Updates webrtc/libjingle to 6070 (https://codereview.chromium.org/272513006/) Reason for revert: Reverting because it introduces two new static initializers: # webrtcvideoengine.cc kVideoCodecClockratekHz # webrtcvideoengine.cc __init_array_end+0x129c8 Please resolve before relanding. Thanks. Original issue's description: > Updates webrtc/libjingle to 6070 > > NOTRY=TRUE > COLLABORATOR=ronghuawu@chromium.org > TBR=ronghuawu > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268764 TBR=ronghuawu@chromium.org,henrika@chromium.org NOTREECHECKS=true NOTRY=true

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

grt (UTC plus 2)

Created Revert of Updates webrtc/libjingle to 6070

6 years, 7 months ago (2014-05-07 15:27:37 UTC) #1

henrika (OOO until Aug 14)

I had already reverted; don't think we need this one.

6 years, 7 months ago (2014-05-07 15:29:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/271593004/1

6 years, 7 months ago (2014-05-07 15:31:58 UTC) #3

grt (UTC plus 2)

6 years, 7 months ago (2014-05-07 16:45:24 UTC) #5

Message was sent while issue was closed.

reverted via drover in https://codereview.chromium.org/267333005 at r268822
since reverting via rietveld was taking too long.