Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: components/browser_watcher/system_session_analyzer_win.cc

Issue 2715903003: Bound the impact of system instability on chrome instability. (Closed)
Patch Set: record start timestamp, analysis metric, make log scrape lazy Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/system_session_analyzer_win.cc
diff --git a/components/browser_watcher/system_session_analyzer_win.cc b/components/browser_watcher/system_session_analyzer_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5a9c2bea56af0e7225a387be012e792ed8d94022
--- /dev/null
+++ b/components/browser_watcher/system_session_analyzer_win.cc
@@ -0,0 +1,232 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/browser_watcher/system_session_analyzer_win.h"
+
+#include <windows.h>
+#include <winevt.h>
+
+#include <utility>
+
+#include "base/time/time.h"
+
+namespace browser_watcher {
+
+namespace {
+
+// The name of the log channel to query.
+const wchar_t kChannelName[] = L"System";
+
+const uint16_t kIdSessionStart = 6005U;
+const uint16_t kIdSessionEnd = 6006U;
+const uint16_t kIdSessionEndUnclean = 6008U;
+
+// An XPATH expression to query for events marking system start or shutdown. The
+// query looks at the following events:
+// - id 6005: "The Event log service was started."
+// - id 6006: "The Event log service was stopped."
+// - id 6008: "The previous system shutdown at <time> on <date> was
+// unexpected."
+// This query is expected to retrieve exactly one event for each startup (id
+// 6005) and one event for each shutdown (either 6006 or 6008).
+const wchar_t kSessionEventsQuery[] =
+ L"*[System[Provider[@Name='eventlog']"
+ L" and (EventID=6005 or EventID=6006 or EventID=6008)]]";
+
+// XPath expressions to attributes of interest.
+const wchar_t kEventIdPath[] = L"Event/System/EventID";
+const wchar_t kEventTimePath[] = L"Event/System/TimeCreated/@SystemTime";
+
+// The timeout to use for calls to ::EvtNext.
+const uint32_t kTimeoutMs = 5000;
+
+struct EvtHandleCloser {
+ using pointer = EVT_HANDLE;
+ void operator()(EVT_HANDLE handle) const {
+ if (handle)
+ ::EvtClose(handle);
+ }
+};
+
+using EvtHandle = std::unique_ptr<EVT_HANDLE, EvtHandleCloser>;
+
+// Create a render context (i.e. specify attributes of interest).
+EvtHandle CreateRenderContext() {
+ LPCWSTR value_paths[] = {kEventIdPath, kEventTimePath};
+ DWORD value_cnt = 2U;
+
+ EVT_HANDLE context = NULL;
+ context =
+ ::EvtCreateRenderContext(value_cnt, value_paths, EvtRenderContextValues);
+ if (!context)
+ PLOG(ERROR) << "Failed to create render context.";
+
+ return EvtHandle(context);
+}
+
+bool GetEventInfo(EVT_HANDLE context,
+ EVT_HANDLE event,
+ SystemSessionEventFetcher::EventInfo* info) {
+ DCHECK(context);
+ DCHECK(event);
+ DCHECK(info);
+
+ std::vector<EVT_VARIANT> buffer(2U);
+ DWORD buffer_size = buffer.size() * sizeof(EVT_VARIANT);
+ DWORD buffer_used = 0U;
+ DWORD value_cnt = 0U;
+
+ if (!::EvtRender(context, event, EvtRenderEventValues, buffer_size,
+ buffer.data(), &buffer_used, &value_cnt)) {
+ PLOG(ERROR) << "Failed to render the event.";
+ return false;
+ }
+
+ if ((buffer[0].Type != EvtVarTypeUInt16) ||
+ (buffer[1].Type != EvtVarTypeFileTime)) {
+ // The types are not what we expect.
+ return false;
+ }
+
+ info->event_id = buffer[0].UInt16Val;
+
+ ULONGLONG time = buffer[1].FileTimeVal;
+ FILETIME ft;
+ ft.dwLowDateTime = static_cast<DWORD>(time & 0xFFFFFFFF);
+
+ ft.dwHighDateTime = static_cast<DWORD>(time >> 32);
+ info->event_time = base::Time::FromFileTime(ft);
+
+ return true;
+}
+
+} // namespace
+
+SystemSessionEventFetcher::SystemSessionEventFetcher(size_t session_cnt)
+ : session_cnt_(session_cnt) {}
+
+bool SystemSessionEventFetcher::FetchEvents(
+ std::vector<EventInfo>* event_infos) const {
+ DCHECK(event_infos);
+
+ // Query for the events. Note: requesting events from newest to oldest.
+ EVT_HANDLE query_raw =
+ ::EvtQuery(nullptr, kChannelName, kSessionEventsQuery,
+ EvtQueryChannelPath | EvtQueryReverseDirection);
+ if (!query_raw) {
+ PLOG(ERROR) << "Event query failed.";
+ return false;
+ }
+ EvtHandle query(query_raw);
+
+ // Retrieve events: 2 events per session, plus the current session's start.
+ size_t desired_event_cnt = 2 * session_cnt_ + 1;
+ std::vector<EVT_HANDLE> events_raw(desired_event_cnt, NULL);
+ DWORD event_cnt = 0U;
+ BOOL success = ::EvtNext(query.get(), desired_event_cnt, events_raw.data(),
+ kTimeoutMs, 0, &event_cnt);
+ if (!success) {
+ // Ensure we capture the last error immediately. Note: returning below to
+ // ensure potential handle cleanup.
+ PLOG(ERROR) << "Failed to retrieve events.";
+ }
+
+ // Ensure handles get closed. The MSDN sample seems to imply handles may need
+ // to be closed event in if EvtNext failed.
+ std::vector<EvtHandle> events(desired_event_cnt);
+ for (size_t i = 0; i < event_cnt; ++i)
+ events[i].reset(events_raw[i]);
+
+ if (!success)
+ return false;
+
+ // Extract information from the events.
+ EvtHandle render_context = CreateRenderContext();
+ if (!render_context.get())
+ return false;
+
+ std::vector<EventInfo> event_infos_tmp;
+ event_infos_tmp.reserve(event_cnt);
+
+ EventInfo info = {};
+ for (size_t i = 0; i < event_cnt; ++i) {
+ if (!GetEventInfo(render_context.get(), events[i].get(), &info))
+ return false;
+ event_infos_tmp.push_back(info);
+ }
+
+ event_infos->swap(event_infos_tmp);
+ return true;
+}
+
+SystemSessionAnalyzer::SystemSessionAnalyzer(
+ std::unique_ptr<SystemSessionEventFetcher> fetcher)
+ : event_fetcher_(std::move(fetcher)) {}
+
+SystemSessionAnalyzer::Status SystemSessionAnalyzer::IsSessionUnclean(
+ base::Time timestamp) {
+ if (!initialized_)
+ Initialize();
+ if (!init_success_)
+ return FAILED;
+ if (timestamp < coverage_start_)
+ return OUTSIDE_RANGE;
+
+ // Get the first session starting after the timestamp.
+ std::map<base::Time, base::TimeDelta>::const_iterator it =
+ unclean_sessions_.upper_bound(timestamp);
+ if (it == unclean_sessions_.begin())
+ return CLEAN; // No prior unclean session.
+
+ // Get the previous session and see if it encompasses the timestamp.
+ --it;
+ bool is_spanned = (timestamp - it->first) <= it->second;
+ return is_spanned ? UNCLEAN : CLEAN;
+}
+
+void SystemSessionAnalyzer::Initialize() {
+ initialized_ = true;
+
+ if (!event_fetcher_)
+ return;
+ std::vector<SystemSessionEventFetcher::EventInfo> events;
+ if (!event_fetcher_->FetchEvents(&events))
+ return;
+
+ // Validate the number and ordering of events (newest to oldest).
+ size_t event_cnt = events.size();
+ if ((event_cnt % 2) == 0)
+ return; // Even number is unexpected.
+ if (event_cnt < 3)
+ return; // Not enough data for a single session.
+ for (size_t i = 1; i < event_cnt; ++i) {
+ if (events[i - 1].event_time < events[i].event_time)
+ return;
+ }
+
+ std::map<base::Time, base::TimeDelta> unclean_sessions;
+ size_t start = 2U;
+ size_t end = 1U;
+ for (; start < event_cnt && end < event_cnt; start += 2, end += 2) {
+ uint16_t start_id = events[start].event_id;
+ uint16_t end_id = events[end].event_id;
+ if (start_id != kIdSessionStart)
+ return;
+ if (end_id != kIdSessionEnd && end_id != kIdSessionEndUnclean)
+ return;
+
+ if (end_id == kIdSessionEnd)
+ continue;
+
+ unclean_sessions.insert(
+ std::make_pair(events[start].event_time,
+ events[end].event_time - events[start].event_time));
+ }
+
+ unclean_sessions_.swap(unclean_sessions);
+ coverage_start_ = events[event_cnt - 1].event_time;
+ init_success_ = true;
+}
+
+} // namespace browser_watcher

Powered by Google App Engine
This is Rietveld 408576698