Chromium Code Reviews| Index: components/browser_watcher/postmortem_report_collector.h |
| diff --git a/components/browser_watcher/postmortem_report_collector.h b/components/browser_watcher/postmortem_report_collector.h |
| index 0650d37ece41cd8ae99b3ebf5572822a61e63968..15df308eec8a5b6ff324e5200e096b4efc59e3d5 100644 |
| --- a/components/browser_watcher/postmortem_report_collector.h |
| +++ b/components/browser_watcher/postmortem_report_collector.h |
| @@ -22,6 +22,7 @@ |
| #include "base/macros.h" |
| #include "base/strings/string16.h" |
| #include "components/browser_watcher/stability_report.pb.h" |
| +#include "components/browser_watcher/system_session_analyzer_win.h" |
| #include "third_party/crashpad/crashpad/client/crash_report_database.h" |
| namespace browser_watcher { |
| @@ -46,8 +47,9 @@ class PostmortemReportCollector { |
| PostmortemReportCollector(const std::string& product_name, |
| const std::string& version_number, |
| - const std::string& channel_name); |
| - virtual ~PostmortemReportCollector() = default; |
| + const std::string& channel_name, |
| + SystemSessionAnalyzer* analyzer); |
| + virtual ~PostmortemReportCollector(); |
| // Collects postmortem stability reports from files found in |debug_info_dir|, |
| // relying on |debug_file_pattern| and |excluded_debug_files|. Reports are |
| @@ -84,6 +86,9 @@ class PostmortemReportCollector { |
| FRIEND_TEST_ALL_PREFIXES( |
| PostmortemReportCollectorCollectionFromGlobalTrackerTest, |
| ModuleCollection); |
| + FRIEND_TEST_ALL_PREFIXES( |
| + PostmortemReportCollectorCollectionFromGlobalTrackerTest, |
| + SystemStateTest); |
| // Virtual for unittesting. |
| virtual std::vector<base::FilePath> GetDebugStateFilePaths( |
| @@ -100,6 +105,8 @@ class PostmortemReportCollector { |
| // TODO(manzagop): move this for reuse in live scenario. |
| virtual CollectionStatus Collect(const base::FilePath& debug_state_file, |
|
Sigurður Ásgeirsson
2017/03/02 21:52:58
Nit: It would help the poor reader if there were a
manzagop (departed)
2017/03/06 15:37:40
If you're ok with it, let's leave that for https:/
|
| std::unique_ptr<StabilityReport>* report); |
| + void SetReporterDetails(StabilityReport* report) const; |
| + void DetermineSystemState(StabilityReport* report) const; |
| void CollectThread( |
| const base::debug::ThreadActivityAnalyzer::Snapshot& snapshot, |
| ThreadState* thread_state); |
| @@ -113,6 +120,8 @@ class PostmortemReportCollector { |
| std::string version_number_; |
| std::string channel_name_; |
| + SystemSessionAnalyzer* system_session_analyzer_; // Not owned. |
| + |
| DISALLOW_COPY_AND_ASSIGN(PostmortemReportCollector); |
| }; |