Bound the impact of system instability on chrome instability.

components/browser_watcher/watcher_metrics_provider_win.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browser_watcher/watcher_metrics_provider_win.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <memory>
 #include <set>
+#include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_base.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/process/process.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/registry.h"
 #include "components/browser_watcher/features.h"
 #include "components/browser_watcher/postmortem_report_collector.h"
 #include "components/browser_watcher/stability_debugging.h"
+#include "components/browser_watcher/system_session_analyzer_win.h"
 #include "third_party/crashpad/crashpad/client/crash_report_database.h"
 
 namespace browser_watcher {
 
 namespace {
 
 // Process ID APIs on Windows talk in DWORDs, whereas for string formatting
 // and parsing, this code uses int. In practice there are no process IDs with
 // the high bit set on Windows, so there's no danger of overflow if this is
 // done consistently.
@@ skipping 218 matching lines @@
   std::unique_ptr<crashpad::CrashReportDatabase> crashpad_database =
       crashpad::CrashReportDatabase::InitializeWithoutCreating(crash_dir_);
   if (!crashpad_database) {
     LOG(ERROR) << "Failed to initialize a CrashPad database.";
     LogCollectionInitStatus(CRASHPAD_DATABASE_INIT_FAILED);
     return;
   }
 
   LogCollectionInitStatus(INIT_SUCCESS);
 
-  // TODO(manzagop): fix incorrect version attribution on update.
+  // Get the reporter's version details.
   base::string16 product_name, version_number, channel_name;
   exe_details_cb_.Run(&product_name, &version_number, &channel_name);
-  PostmortemReportCollector collector(base::UTF16ToUTF8(product_name),
-                                      base::UTF16ToUTF8(version_number),
-                                      base::UTF16ToUTF8(channel_name));
+
+  const size_t kSystemSessionsToInspect = 5U;
+  std::unique_ptr<SystemSessionEventFetcher> fetcher(

[Sigurður Ásgeirsson, 2017/03/01 15:09:27]

why can't these be simple locals? why the allocation?
Are these things posting tasks and bouncing around threads?

[manzagop (departed), 2017/03/01 21:07:45]

No reason. Done.

+      new SystemSessionEventFetcher(kSystemSessionsToInspect));
+  std::unique_ptr<SystemSessionAnalyzer> analyzer(
+      new SystemSessionAnalyzer(std::move(fetcher)));
+
+  PostmortemReportCollector collector(
+      base::UTF16ToUTF8(product_name), base::UTF16ToUTF8(version_number),
+      base::UTF16ToUTF8(channel_name), std::move(analyzer));
   collector.CollectAndSubmitForUpload(stability_dir, GetStabilityFilePattern(),
                                       excluded_debug_files,
                                       crashpad_database.get());
 }
 
 }  // namespace browser_watcher