Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: content/child/push_messaging/push_provider.h

Issue 2715903002: Re-design Unsubscribe and getPermissionStatus mojo interfaces. (Closed)
Patch Set: Re-design Unsubscribe and getPermissionStatus mojo interfaces. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/push_messaging/push_provider.h
diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h
index 5f89d7ffe11ec84204af2ed672368229db43ce7f..b5766f3a0a41a67d87a923d12d2b6b3fc3bceb4a 100644
--- a/content/child/push_messaging/push_provider.h
+++ b/content/child/push_messaging/push_provider.h
@@ -77,9 +77,8 @@ class PushProvider : public blink::WebPushProvider,
void DidUnsubscribe(
std::unique_ptr<blink::WebPushUnsubscribeCallbacks> callbacks,
- bool is_success,
- bool did_unsubscribe,
blink::WebPushError::ErrorType error_type,
+ bool did_unsubscribe,
const base::Optional<std::string>& error_message);
void DidGetSubscription(
@@ -92,9 +91,8 @@ class PushProvider : public blink::WebPushProvider,
void DidGetPermissionStatus(
std::unique_ptr<blink::WebPushPermissionStatusCallbacks> callbacks,
- bool is_success,
- blink::WebPushPermissionStatus status,
- blink::WebPushError::ErrorType error);
+ blink::WebPushError::ErrorType error_type,
+ blink::WebPushPermissionStatus status);
mojom::PushMessagingPtr push_messaging_manager_;
« no previous file with comments | « content/browser/push_messaging/push_messaging_manager.cc ('k') | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698