Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/modules/push_messaging/PushError.cpp

Issue 2715903002: Re-design Unsubscribe and getPermissionStatus mojo interfaces. (Closed)
Patch Set: change ErrorType::Unknown to ErrorType::None Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/push_messaging/PushError.h" 5 #include "modules/push_messaging/PushError.h"
6 6
7 #include "core/dom/DOMException.h" 7 #include "core/dom/DOMException.h"
8 #include "core/dom/ExceptionCode.h" 8 #include "core/dom/ExceptionCode.h"
9 #include "wtf/Assertions.h" 9 #include "wtf/Assertions.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 DOMException* PushError::take(ScriptPromiseResolver*, 13 DOMException* PushError::take(ScriptPromiseResolver*,
14 const WebPushError& webError) { 14 const WebPushError& webError) {
15 switch (webError.errorType) { 15 switch (webError.errorType) {
16 case WebPushError::ErrorTypeAbort: 16 case WebPushError::ErrorTypeAbort:
17 return DOMException::create(AbortError, webError.message); 17 return DOMException::create(AbortError, webError.message);
18 case WebPushError::ErrorTypeInvalidState: 18 case WebPushError::ErrorTypeInvalidState:
19 return DOMException::create(InvalidStateError, webError.message); 19 return DOMException::create(InvalidStateError, webError.message);
20 case WebPushError::ErrorTypeNetwork: 20 case WebPushError::ErrorTypeNetwork:
21 return DOMException::create(NetworkError, webError.message); 21 return DOMException::create(NetworkError, webError.message);
22 case WebPushError::ErrorTypeNone:
23 NOTREACHED();
24 return DOMException::create(UnknownError);
Peter Beverloo 2017/02/27 09:32:50 nit: just stick webError.message in there too, eve
ke.he 2017/02/28 05:00:50 Done.
22 case WebPushError::ErrorTypeNotAllowed: 25 case WebPushError::ErrorTypeNotAllowed:
23 return DOMException::create(NotAllowedError, webError.message); 26 return DOMException::create(NotAllowedError, webError.message);
24 case WebPushError::ErrorTypeNotFound: 27 case WebPushError::ErrorTypeNotFound:
25 return DOMException::create(NotFoundError, webError.message); 28 return DOMException::create(NotFoundError, webError.message);
26 case WebPushError::ErrorTypeNotSupported: 29 case WebPushError::ErrorTypeNotSupported:
27 return DOMException::create(NotSupportedError, webError.message); 30 return DOMException::create(NotSupportedError, webError.message);
28 case WebPushError::ErrorTypeUnknown:
29 return DOMException::create(UnknownError, webError.message);
30 } 31 }
31 NOTREACHED(); 32 NOTREACHED();
32 return DOMException::create(UnknownError); 33 return DOMException::create(UnknownError);
33 } 34 }
34 35
35 } // namespace blink 36 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698