Avoid race crash: Don't drop reference to URL fetcher until data is extracted...

chrome/browser/spellchecker.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
 #include "base/logging.h"
@@ skipping 232 matching lines @@
  public:
   DictionaryDownloadController(
       Task* spellchecker_flag_set_task,
       const FilePath& dic_file_path,
       URLRequestContext* url_request_context,
       MessageLoop* ui_loop)
       : spellchecker_flag_set_task_(spellchecker_flag_set_task),
         url_request_context_(url_request_context),
         ui_loop_(ui_loop) {
     // Determine dictionary file path and name.
-    fetcher_.reset(NULL);
     dic_zip_file_path_ = dic_file_path.DirName();
     file_name_ = dic_file_path.BaseName();
   }
 
   // Save the file in memory buffer to the designated dictionary file.
   // returns the number of bytes it could save.
   // Invoke this on the file thread.
   void StartDownload() {
     static const char kDownloadServerUrl[] =
         "http://cache.pack.google.com/edgedl/chrome/dict/";
@@ skipping 15 matching lines @@
   }
 
   // URLFetcher::Delegate interface.
   virtual void OnURLFetchComplete(const URLFetcher* source,
                                   const GURL& url,
                                   const URLRequestStatus& status,
                                   int response_code,
                                   const ResponseCookies& cookies,
                                   const std::string& data) {
     DCHECK(source);
-    fetcher_.reset(NULL);
     bool save_success = false;
     if ((response_code / 100) == 2 ||
         response_code == 401 ||
         response_code == 407) {
       save_success = SaveBufferToFile(data);
     }  // Unsuccessful save is taken care of in SpellChecker::Initialize().
 
     // Set Flag that dictionary is not downloading anymore.
     ui_loop_->PostTask(FROM_HERE,
                        new UIProxyForIOTask(spellchecker_flag_set_task_));
+    fetcher_.reset(NULL);
   }
 
   // factory object to invokelater back to spellchecker in io thread on
   // download completion to change appropriate flags.
   Task* spellchecker_flag_set_task_;
 
   // URLRequestContext to be used by URLFetcher. This is obtained from profile.
   // The ownership remains with the profile.
   URLRequestContext* url_request_context_;
 
@@ skipping 22 matching lines @@
 FilePath SpellChecker::GetVersionedFileName(const Language& input_language,
                                             const FilePath& dict_dir) {
   // The default version string currently in use.
   static const wchar_t kDefaultVersionString[] = L"-1-2";
 
   // Use this struct to insert version strings for dictionary files which have
   // special version strings, other than the default version string. For eight
   // languages (included below in the struct), the version is kept at 1-1. The
   // others (19 of them) have been updated to new default version 1-2 which
   // contains many new words.
-  // TODO (sidchat): Work on these 8 languages to bring them upto version 1-2.
+  // TODO(sidchat): Work on these 8 languages to bring them upto version 1-2.
   static const struct {
     // The language input.
     const char* language;
 
     // The corresponding version.
     const char* version;
   } special_version_string[] = {
     {"en-GB", "-1-1"},
     {"es-ES", "-1-1"},
     {"nl-NL", "-1-1"},
@@ skipping 116 matching lines @@
   DHISTOGRAM_TIMES("Spellcheck.InitTime", TimeTicks::Now() - begin_time);
 
   tried_to_init_ = true;
   return false;
 }
 
 void SpellChecker::AddCustomWordsToHunspell() {
   // Add custom words to Hunspell.
   // This should be done in File Loop, but since Hunspell is in this IO Loop,
   // this too has to be initialized here.
-  // TODO (sidchat): Work out a way to initialize Hunspell in the File Loop.
+  // TODO(sidchat): Work out a way to initialize Hunspell in the File Loop.
   std::string contents;
   file_util::ReadFileToString(custom_dictionary_file_name_, &contents);
   std::vector<std::string> list_of_words;
   SplitString(contents, '\n', &list_of_words);
   if (hunspell_.get()) {
     for (std::vector<std::string>::iterator it = list_of_words.begin();
          it != list_of_words.end(); ++it) {
       hunspell_->put_word(it->c_str());
     }
   }
@@ skipping 135 matching lines @@
     hunspell_->put_word(word_to_add.c_str());
 
   // Now add the word to the custom dictionary file.
   Task* write_word_task =
       new AddWordToCustomDictionaryTask(custom_dictionary_file_name_, word);
   if (file_loop_)
     file_loop_->PostTask(FROM_HERE, write_word_task);
   else
     write_word_task->Run();
 }