chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc - Issue 2715823004: Add FingerprintUnlock KeyedService for each profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

Issue 2715823004: Add FingerprintUnlock KeyedService for each profile (Closed)

Patch Set: Incorporate comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/BUILD.gn ('k') | chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc » ('j') | chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

index 6b79bca373deab8122c48966a6ff7024130719fa..9e60b8da46a0bd81a121639487b3494fbf54c5c6 100644

--- a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

+++ b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

@@ -5,8 +5,8 @@

#include "chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h"

#include "base/memory/ptr_util.h"

-#include "chrome/browser/chromeos/login/quick_unlock/pin_storage.h"

-#include "chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.h"

+#include "chrome/browser/chromeos/login/quick_unlock/quick_unlock_factory.h"

+#include "chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h"

#include "chrome/browser/chromeos/profiles/profile_helper.h"

#include "chrome/common/pref_names.h"

#include "chromeos/login/auth/extended_authenticator.h"

@@ -49,9 +49,9 @@ const char* kMostCommonPins[] = {"1212", "1004", "2000", "6969",

QuickUnlockModeList ComputeActiveModes(Profile* profile) {

QuickUnlockModeList modes;

- chromeos::quick_unlock::PinStorage* pin_storage =

- chromeos::quick_unlock::PinStorageFactory::GetForProfile(profile);

- if (pin_storage && pin_storage->IsPinSet())

+ chromeos::quick_unlock::QuickUnlockStorage* quick_unlock_storage =

+ chromeos::quick_unlock::QuickUnlockFactory::GetForProfile(profile);

+ if (quick_unlock_storage && quick_unlock_storage->pin_storage()->IsPinSet())

modes.push_back(quick_unlock_private::QUICK_UNLOCK_MODE_PIN);

return modes;

@@ -401,7 +401,8 @@ void QuickUnlockPrivateSetModesFunction::ApplyModeChange() {

if (update_pin) {

Profile* profile = chrome_details_.GetProfile();

chromeos::quick_unlock::PinStorage* pin_storage =

- chromeos::quick_unlock::PinStorageFactory::GetForProfile(profile);

+ chromeos::quick_unlock::QuickUnlockFactory::GetForProfile(profile)

+ ->pin_storage();

if (pin_credential.empty()) {

pin_storage->RemovePin();