Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 2715803004: Introduce ThreadableLoadingContext: make threaded loading code one step away from Document (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
index 7303b3eed99b2cbf6541b82ba89e5a7dc13b4bda..03f776e0b480e45e46549abb306308250f1a7998 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
@@ -52,6 +52,7 @@ class KURL;
class ResourceRequest;
class SecurityOrigin;
class ThreadableLoaderClient;
+class ThreadableLoadingContext;
class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader,
private RawResourceClient {
@@ -63,7 +64,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader,
ThreadableLoaderClient&,
const ThreadableLoaderOptions&,
const ResourceLoaderOptions&);
- static DocumentThreadableLoader* create(Document&,
+ static DocumentThreadableLoader* create(ThreadableLoadingContext&,
ThreadableLoaderClient*,
const ThreadableLoaderOptions&,
const ResourceLoaderOptions&);
@@ -81,7 +82,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader,
private:
enum BlockingBehavior { LoadSynchronously, LoadAsynchronously };
- DocumentThreadableLoader(Document&,
+ DocumentThreadableLoader(ThreadableLoadingContext&,
ThreadableLoaderClient*,
BlockingBehavior,
const ThreadableLoaderOptions&,
@@ -182,10 +183,12 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader,
// End of ResourceOwner re-implementation, see above.
const SecurityOrigin* getSecurityOrigin() const;
- Document& document() const;
+
+ // TODO(kinuko): Remove dependency to document.
+ Document* document() const;
ThreadableLoaderClient* m_client;
- Member<Document> m_document;
+ Member<ThreadableLoadingContext> m_loadingContext;
const ThreadableLoaderOptions m_options;
// Some items may be overridden by m_forceDoNotAllowStoredCredentials and
« no previous file with comments | « third_party/WebKit/Source/core/loader/BUILD.gn ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698