Introduce ThreadableLoadingContext: make threaded loading code one step away from Document

third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013, Intel Corporation
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 31 matching lines @@
 #include "platform/network/ResourceError.h"
 #include "platform/weborigin/Referrer.h"
 #include "wtf/Forward.h"
 #include "wtf/text/WTFString.h"
 #include <memory>
 
 namespace blink {
 
 class Document;
 class KURL;
+class LoadingContext;
 class ResourceRequest;
 class SecurityOrigin;
 class ThreadableLoaderClient;
 
 class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader,
                                                    private RawResourceClient {
   USING_GARBAGE_COLLECTED_MIXIN(DocumentThreadableLoader);
 
  public:
   static void loadResourceSynchronously(Document&,
                                         const ResourceRequest&,
                                         ThreadableLoaderClient&,
                                         const ThreadableLoaderOptions&,
                                         const ResourceLoaderOptions&);
   static DocumentThreadableLoader* create(Document&,
                                           ThreadableLoaderClient*,
                                           const ThreadableLoaderOptions&,
                                           const ResourceLoaderOptions&);
+  static DocumentThreadableLoader* create(LoadingContext&,
+                                          ThreadableLoaderClient*,
+                                          const ThreadableLoaderOptions&,
+                                          const ResourceLoaderOptions&);
   ~DocumentThreadableLoader() override;
 
   void start(const ResourceRequest&) override;
 
   void overrideTimeout(unsigned long timeout) override;
 
   void cancel() override;
   void setDefersLoading(bool);
 
   DECLARE_TRACE();
 
  private:
   enum BlockingBehavior { LoadSynchronously, LoadAsynchronously };
 
-  DocumentThreadableLoader(Document&,
+  DocumentThreadableLoader(LoadingContext&,

[horo, 2017/02/27 04:49:20]

Why do you use reference instead of pointer?

[kinuko, 2017/02/27 04:55:35]

Just to indicate this should never be null.

                            ThreadableLoaderClient*,
                            BlockingBehavior,
                            const ThreadableLoaderOptions&,
                            const ResourceLoaderOptions&);
 
   void clear();
 
   // ResourceClient
   void notifyFinished(Resource*) override;
 
@@ skipping 80 matching lines @@
     if (newResource) {
       m_resource = newResource;
       m_checker.willAddClient();
       m_resource->addClient(this);
     }
   }
   Member<RawResource> m_resource;
   // End of ResourceOwner re-implementation, see above.
 
   const SecurityOrigin* getSecurityOrigin() const;
-  Document& document() const;
+
+  // TODO(kinuko): Remove dependency to document.
+  Document* document() const;
 
   ThreadableLoaderClient* m_client;
-  Member<Document> m_document;
+  Member<LoadingContext> m_loadingContext;
 
   const ThreadableLoaderOptions m_options;
   // Some items may be overridden by m_forceDoNotAllowStoredCredentials and
   // m_securityOrigin. In such a case, build a ResourceLoaderOptions with
   // up-to-date values from them and this variable, and use it.
   const ResourceLoaderOptions m_resourceLoaderOptions;
 
   bool m_forceDoNotAllowStoredCredentials;
   RefPtr<SecurityOrigin> m_securityOrigin;
 
@@ skipping 37 matching lines @@
   // used to populate the HTTP Referer header when following the redirect.
   bool m_overrideReferrer;
   Referrer m_referrerAfterRedirect;
 
   RawResourceClientStateChecker m_checker;
 };
 
 }  // namespace blink
 
 #endif  // DocumentThreadableLoader_h