Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2715783002: [DevTools] Fix 'node targets available' not appearing, but listed in Remote Devices drawer tab. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {SDK.SDKModelObserver<!SDK.DebuggerModel>} 5 * @implements {SDK.SDKModelObserver<!SDK.DebuggerModel>}
6 * @implements {UI.ListDelegate<!SDK.DebuggerModel>} 6 * @implements {UI.ListDelegate<!SDK.DebuggerModel>}
7 */ 7 */
8 Sources.ThreadsSidebarPane = class extends UI.VBox { 8 Sources.ThreadsSidebarPane = class extends UI.VBox {
9 constructor() { 9 constructor() {
10 super(true); 10 super(true);
11 this.registerRequiredCSS('sources/threadsSidebarPane.css'); 11 this.registerRequiredCSS('sources/threadsSidebarPane.css');
12 12
13 this._availableNodeTargetsElement = this.element.createChild('div', 'hidden available-node-targets');
14
15 /** @type {!UI.ListControl<!SDK.DebuggerModel>} */ 13 /** @type {!UI.ListControl<!SDK.DebuggerModel>} */
16 this._list = new UI.ListControl(this, UI.ListMode.NonViewport); 14 this._list = new UI.ListControl(this, UI.ListMode.NonViewport);
17 this.contentElement.appendChild(this._list.element); 15 this.contentElement.appendChild(this._list.element);
18 16
17 this._availableNodeTargetsElement = this.contentElement.createChild('div', ' hidden available-node-targets');
18
19 UI.context.addFlavorChangeListener(SDK.Target, this._targetFlavorChanged, th is); 19 UI.context.addFlavorChangeListener(SDK.Target, this._targetFlavorChanged, th is);
20 20
21 SDK.targetManager.addModelListener( 21 SDK.targetManager.addModelListener(
22 SDK.SubTargetsManager, SDK.SubTargetsManager.Events.AvailableNodeTargets Changed, 22 SDK.SubTargetsManager, SDK.SubTargetsManager.Events.AvailableNodeTargets Changed,
23 this._availableNodeTargetsChanged, this); 23 this._availableNodeTargetsChanged, this);
24 this._availableNodeTargetsChanged(); 24 this._availableNodeTargetsChanged();
25 25
26 SDK.targetManager.observeModels(SDK.DebuggerModel, this); 26 SDK.targetManager.observeModels(SDK.DebuggerModel, this);
27 } 27 }
28 28
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 /** 163 /**
164 * @param {!Common.Event} event 164 * @param {!Common.Event} event
165 */ 165 */
166 _targetFlavorChanged(event) { 166 _targetFlavorChanged(event) {
167 var target = /** @type {!SDK.Target} */ (event.data); 167 var target = /** @type {!SDK.Target} */ (event.data);
168 var debuggerModel = target.model(SDK.DebuggerModel); 168 var debuggerModel = target.model(SDK.DebuggerModel);
169 if (debuggerModel) 169 if (debuggerModel)
170 this._list.selectItem(debuggerModel); 170 this._list.selectItem(debuggerModel);
171 } 171 }
172 }; 172 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698