Issue 2715743006: Add QuicFlagUtils to quic/platform. No behavior change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2715743006: Add QuicFlagUtils to quic/platform. No behavior change. (Closed)

Created:
3 years, 10 months ago by Victor Vasiliev

Modified:
3 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add QuicFlagUtils to quic/platform. No behavior change. Merge internal change: 147743869 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -0 lines)			Patch
M	net/BUILD.gn	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	net/quic/platform/api/quic_flag_utils.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	net/quic/platform/impl/quic_flag_utils_impl.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2713963003 Patch 1

Dependent Patchsets:

Issue 2713773005 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

3 years, 10 months ago (2017-02-24 01:46:07 UTC) #2

There was just an internal CL which defined these methods to be do {} while
(false) and had some motivation for why that's a better thing to do. You might
consider doing that instead.

Expand Messages | Collapse Messages