Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: ui/events/event_processor.cc

Issue 2715743005: Revert of Avoid two targeting phases in aura client-lib and EventProcessor. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event_processor.h ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event_processor.cc
diff --git a/ui/events/event_processor.cc b/ui/events/event_processor.cc
index 39678dc26e7e2fd2eb4e239837e64f2897775db7..61d2e72138a8dc51beb04f960b19197d715c750d 100644
--- a/ui/events/event_processor.cc
+++ b/ui/events/event_processor.cc
@@ -10,6 +10,11 @@
namespace ui {
EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
+ EventTarget* root = GetRootTarget();
+ CHECK(root);
+ EventTargeter* targeter = root->GetEventTargeter();
+ CHECK(targeter);
+
// If |event| is in the process of being dispatched or has already been
// dispatched, then dispatch a copy of the event instead.
bool dispatch_original_event = event->phase() == EP_PREDISPATCH;
@@ -21,22 +26,9 @@
}
OnEventProcessingStarted(event_to_dispatch);
- EventTarget* target = nullptr;
- EventTargeter* targeter = nullptr;
- if (!event_to_dispatch->handled()) {
- target = event->target();
- EventTarget* root = GetRootForEvent(event_to_dispatch);
- DCHECK(root);
- targeter = root->GetEventTargeter();
- if (!targeter) {
- targeter = GetDefaultEventTargeter();
- if (!target)
- target = targeter->FindTargetForEvent(root, event_to_dispatch);
- } else {
- target = targeter->FindTargetForEvent(root, event_to_dispatch);
- }
- DCHECK(targeter);
- }
+ EventTarget* target = NULL;
+ if (!event_to_dispatch->handled())
+ target = targeter->FindTargetForEvent(root, event_to_dispatch);
EventDispatchDetails details;
while (target) {
« no previous file with comments | « ui/events/event_processor.h ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698