Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: third_party/WebKit/Source/platform/heap/PageMemory.h

Issue 2715713005: Verify that a new heap page isn't also marked as being off heap. (Closed)
Patch Set: switch to CHECK() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/PageMemory.h
diff --git a/third_party/WebKit/Source/platform/heap/PageMemory.h b/third_party/WebKit/Source/platform/heap/PageMemory.h
index 6e1e87a24d91de89b067376e31b5d8f808f8808b..2407eed99491efd485ad97e10ab89ddc9a348d48 100644
--- a/third_party/WebKit/Source/platform/heap/PageMemory.h
+++ b/third_party/WebKit/Source/platform/heap/PageMemory.h
@@ -174,6 +174,15 @@ class PageMemory {
WARN_UNUSED_RESULT bool commit() {
m_reserved->markPageUsed(writableStart());
+ // Check that in-use page isn't also marked as being a non-heap page
+ // by the current heap's negative cache. That cache is invalidated
+ // when allocating new pages, but crbug.com/649485 suggests that
+ // we do get out of sync somehow.
+ //
+ // TODO(sof): consider removing check once bug has been diagnosed
+ // and addressed.
+ CHECK(!ThreadState::current()->isAddressInHeapDoesNotContainCache(
+ writableStart()));
return m_writable.commit();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698