third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h - Issue 2715663002: ServiceWorker: Factor out FetchEvent related logics from RespondWithObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h

Issue 2715663002: ServiceWorker: Factor out FetchEvent related logics from RespondWithObserver. (Closed)

Patch Set: ServiceWorker: Factor out FetchEvent related logics from RespondWithObserver. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h

index 44892681d3ffd366983090f1ed8684b3b0a07e1f..012bde47363ce699906a613188ee2253f4e6863d 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h

@@ -5,14 +5,14 @@

#ifndef ForeignFetchRespondWithObserver_h

#define ForeignFetchRespondWithObserver_h

-#include "modules/serviceworkers/RespondWithObserver.h"

+#include "modules/serviceworkers/FetchRespondWithObserver.h"

namespace blink {

// This class observes the service worker's handling of a ForeignFetchEvent and

// notifies the client.

class MODULES_EXPORT ForeignFetchRespondWithObserver final

- : public RespondWithObserver {

+ : public FetchRespondWithObserver {

public:

static ForeignFetchRespondWithObserver* create(

ExecutionContext*,

@@ -25,7 +25,7 @@ class MODULES_EXPORT ForeignFetchRespondWithObserver final

PassRefPtr<SecurityOrigin>,

WaitUntilObserver*);

- void responseWasFulfilled(const ScriptValue&) override;

+ void onResponseFulfilled(const ScriptValue&) override;

private:

ForeignFetchRespondWithObserver(ExecutionContext*,