third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp - Issue 2715663002: ServiceWorker: Factor out FetchEvent related logics from RespondWithObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2715663002: ServiceWorker: Factor out FetchEvent related logics from RespondWithObserver. (Closed)

Patch Set: ServiceWorker: Factor out FetchEvent related logics from RespondWithObserver. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

index 8f4f9a01776170ab3cd3d5a5a4dedf2b40072320..9d394618e8f5b7ecd4e5e3cf2349167c631688aa 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

@@ -10,6 +10,7 @@

#include "modules/fetch/BytesConsumerForDataConsumerHandle.h"

#include "modules/fetch/Request.h"

#include "modules/fetch/Response.h"

+#include "modules/serviceworkers/FetchRespondWithObserver.h"

#include "modules/serviceworkers/ServiceWorkerError.h"

#include "modules/serviceworkers/ServiceWorkerGlobalScope.h"

#include "public/platform/WebURLResponse.h"

@@ -29,7 +30,7 @@ FetchEvent* FetchEvent::create(ScriptState* scriptState,

FetchEvent* FetchEvent::create(ScriptState* scriptState,

const AtomicString& type,

const FetchEventInit& initializer,

- RespondWithObserver* respondWithObserver,

+ FetchRespondWithObserver* respondWithObserver,

WaitUntilObserver* waitUntilObserver,

bool navigationPreloadSent) {

return new FetchEvent(scriptState, type, initializer, respondWithObserver,

@@ -67,7 +68,7 @@ const AtomicString& FetchEvent::interfaceName() const {

FetchEvent::FetchEvent(ScriptState* scriptState,

const AtomicString& type,

const FetchEventInit& initializer,

- RespondWithObserver* respondWithObserver,

+ FetchRespondWithObserver* respondWithObserver,

WaitUntilObserver* waitUntilObserver,

bool navigationPreloadSent)

: ExtendableEvent(type, initializer, waitUntilObserver),