Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 271563002: Fixed wrong test (Closed)

Created:
6 years, 7 months ago by pgervais
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M presubmit_support.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pgervais
Any modified .DEPS.git files triggered a bug in this line. Can we move quick on ...
6 years, 7 months ago (2014-05-07 00:47:30 UTC) #1
Dirk Pranke
lgtm
6 years, 7 months ago (2014-05-07 00:50:28 UTC) #2
ghost stip (do not use)
lgtm, yikes
6 years, 7 months ago (2014-05-07 00:52:43 UTC) #3
pgervais
The CQ bit was checked by pgervais@chromium.org
6 years, 7 months ago (2014-05-07 00:55:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgervais@chromium.org/271563002/1
6 years, 7 months ago (2014-05-07 00:56:30 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 00:58:14 UTC) #6
Message was sent while issue was closed.
Change committed as 268647

Powered by Google App Engine
This is Rietveld 408576698