Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 27156004: Properly export uin32_bias double constant. (Closed)

Created:
7 years, 2 months ago by oliv
Modified:
7 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Properly export uin32_bias double constant. This makes LoadUint32 snapshot safe. BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17223

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/serialize.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 2 months ago (2013-10-14 11:07:13 UTC) #1
Sven Panne
lgtm
7 years, 2 months ago (2013-10-14 12:03:49 UTC) #2
oliv
7 years, 2 months ago (2013-10-15 16:12:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698