chrome/browser/extensions/requirements_checker_browsertest.cc - Issue 2715563002: Moving SwiftShader from component to bundled library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/requirements_checker_browsertest.cc

Issue 2715563002: Moving SwiftShader from component to bundled library (Closed)

Patch Set: Prevented !GpuAccessAllowed() from enabling SwiftShader Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/requirements_checker_browsertest.cc

diff --git a/chrome/browser/extensions/requirements_checker_browsertest.cc b/chrome/browser/extensions/requirements_checker_browsertest.cc

index 12b8491f806abef35e280f2c51d747f619e928d6..5b8547e7883b6db00cd390aade62ef8913199bbc 100644

--- a/chrome/browser/extensions/requirements_checker_browsertest.cc

+++ b/chrome/browser/extensions/requirements_checker_browsertest.cc

@@ -136,8 +136,10 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowWebGL) {

content::RunAllBlockingPoolTasksUntilIdle();

std::vector<std::string> expected_errors;

- expected_errors.push_back(l10n_util::GetStringUTF8(

- IDS_EXTENSION_WEBGL_NOT_SUPPORTED));

+ if (!content::GpuDataManager::GetInstance()->ShouldUseSwiftShader()) {

+ expected_errors.push_back(

+ l10n_util::GetStringUTF8(IDS_EXTENSION_WEBGL_NOT_SUPPORTED));

+ }

checker_->Check(extension, base::Bind(

&RequirementsCheckerBrowserTest::ValidateRequirementErrors,