content/browser/gpu/gpu_data_manager_impl.h - Issue 2715563002: Moving SwiftShader from component to bundled library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl.h

Issue 2715563002: Moving SwiftShader from component to bundled library (Closed)

Patch Set: Fixed nits and some unit tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/gpu/gpu_data_manager_impl.h

diff --git a/content/browser/gpu/gpu_data_manager_impl.h b/content/browser/gpu/gpu_data_manager_impl.h

index ad03965d44456095f1ba0a30d2f82c630b3ce6dc..4c6097f1959376face8fce405f86c1737143558b 100644

--- a/content/browser/gpu/gpu_data_manager_impl.h

+++ b/content/browser/gpu/gpu_data_manager_impl.h

@@ -79,7 +79,6 @@ class CONTENT_EXPORT GpuDataManagerImpl

bool IsCompleteGpuInfoAvailable() const override;

void RequestVideoMemoryUsageStatsUpdate() const override;

bool ShouldUseSwiftShader() const override;

- void RegisterSwiftShaderPath(const base::FilePath& path) override;

// TODO(kbr): the threading model for the GpuDataManagerObservers is

// not well defined, and it's impossible for callers to correctly

// delete observers from anywhere except in one of the observer's