Moving SwiftShader from component to bundled library

chrome/tools/build/win/FILES.cfg

 # -*- python -*-
 # ex: set syntax=python:
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is a buildbot configuration file containing a tagged list of files
 # processed by the stage/archive scripts. The known tags are:
 #
@@ skipping 364 matching lines @@
   {
     'filename': 'libEGL.dll',
     'buildtype': ['dev', 'official'],
     'filegroup': ['default', 'symsrc'],
   },
   {
     'filename': 'libGLESv2.dll',
     'buildtype': ['dev', 'official'],
     'filegroup': ['default', 'symsrc'],
   },
+  # SwiftShader files:
+  {
+    'filename': 'swiftshader/libEGL.dll',

[grt (UTC plus 2), 2017/02/23 15:00:50]

are there pdb files for these as well?

[sugoi, 2017/02/23 15:22:55]

Yes, I think so (I'm not in front of my Windows desktop at the moment, but I
think that there are pdb files generated in the out\Default\swiftshader
directory).

[grt (UTC plus 2), 2017/02/23 15:33:38]

In that case, please add stanzas for the .pdbs as well (see chrome.dll.pdb for
an example).

+    'buildtype': ['dev', 'official'],
+    'filegroup': ['default', 'symsrc'],
+  },
+  {
+    'filename': 'swiftshader/libGLESv2.dll',
+    'buildtype': ['dev', 'official'],
+    'filegroup': ['default', 'symsrc'],
+  },

[Ken Russell (switch to Gerrit), 2017/02/23 01:58:05]

There are conditions like BUILDFLAG(ENABLE_SWIFTSHADER) throughout the code but
I don't see similar conditions in the bundling files. What's the situation here?

[sugoi, 2017/02/23 03:41:31]

Not sure yet, I'm not super knowledgeable about how to configure this file. That
being said, this file is for Windows and ENABLE_SWIFTSHADER is defined as
"is_chrome_branded && is_win", which is what this file is used for, if I
understand correctly.

   # Native Client plugin files:
   {
     'filename': 'nacl_irt_x86_32.nexe',
     'arch': ['32bit'],
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'nacl_irt_x86_64.nexe',
     'buildtype': ['dev', 'official'],
   },
@@ skipping 346 matching lines @@
     'archive': 'content-shell.zip',
     'optional': ['dev'],
   },
   {
     'filename': 'resources',
     'buildtype': ['dev'],
     'archive': 'content-shell.zip',
     'optional': ['dev'],
   },
 ]