Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2715533008: Run src/task/strong tests with analysis driver. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -24 lines) Patch
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +133 lines, -3 lines 1 comment Download
M pkg/analyzer/test/src/task/strong/non_null_checker_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 5 chunks +34 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
3 years, 10 months ago (2017-02-23 21:59:37 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-23 22:05:10 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 48714187b3d22f264b5dab3cd146431787e411b8 (presubmit successful).
3 years, 10 months ago (2017-02-23 22:14:03 UTC) #4
Leaf
3 years, 10 months ago (2017-02-23 22:26:41 UTC) #6
Message was sent while issue was closed.
Thanks!  I commented on one failing test that I think should be supported now. 
The rest I think can wait on the new top level inference.

https://codereview.chromium.org/2715533008/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/2715533008/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:5497:
test_inferCorrectlyOnMultipleVariablesDeclaredTogether() async {
I think this should be handled.

Powered by Google App Engine
This is Rietveld 408576698