Use ScriptLoader::errorOccurred() instead of Resource in ScriptLoader

third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
index e32b4516f1b353bdf0e889e6dcee3554dd61e551..3f5c8297c8c12246acf6b2510707efb4069c5ca0 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
@@ -854,7 +854,7 @@ void ScriptLoader::pendingScriptFinished(PendingScript* pendingScript) {
 
   DCHECK_EQ(pendingScript->resource(), m_resource);

[sof, 2017/02/24 07:29:22]

Given the DCHECK_EQ() at the start of this method, we don't need this one also.

[hiroshige, 2017/02/24 18:16:57]

The DCHECK_EQ() at the start of this method checks that
|m_pendingScript == pendingScript|, and
this DCHECK_EQ() virtually checks that
|m_pendingScript->resource() == m_resource|, and
I think these are two orthogonal assumptions
and are useful to catch current bugs or future regressions.

[sof, 2017/02/24 18:26:43]

If you really think that's valuable, then move it up next to that other
DCHECK_EQ() ?

[hiroshige, 2017/02/25 00:31:50]

Done.

 
-  if (m_resource->errorOccurred()) {
+  if (errorOccurred()) {
     contextDocument->scriptRunner()->notifyScriptLoadError(this,
                                                            m_asyncExecType);
     detachPendingScript();