[Payments] Add error messages to credit card editor.

chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h

Index: chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
diff --git a/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h b/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
index a7f0843dd3ee277253b9d38d7d49af0cc4edd674..f08ad5d83de064fcbcd649c4fe3ce1f78b8e6ef2 100644
--- a/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
+++ b/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
@@ -26,6 +26,8 @@ enum class DialogViewID : int {
   ORDER_SUMMARY_LINE_ITEM_1,
   ORDER_SUMMARY_LINE_ITEM_2,
   ORDER_SUMMARY_LINE_ITEM_3,
+
+  ERROR_LABEL_OFFSET = 1000,

[anthonyvd, 2017/02/22 19:32:45]

You can omit the 1000 here I think. It's guaranteed to be greater than all the
values above it so the general pattern is to just name it something that
indicates it should be the last element in the enum and add a comment to that
effect. What about DIALOG_VIEW_IDS_MAX?

[Mathieu, 2017/02/22 20:08:59]

You're right I can get rid of the 1000 here, I've set VIEW_ID_NONE to start at
the Autofill type's max. To explain a bit more, this is a slight hack that I'm
using. The input field will have set_id(field.type), (e.g. set_id(56)) and the
error label will have set_id(ERROR_LABEL_OFFSET + 56), so I can recall both
during tests. Here's the autofill types:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/field_t...

Hey don't hate the player, hate the ViewID game!

 };
 
 }  // namespace payments