Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 271553006: Fix activity logging for extension background pages. (Closed)

Created:
6 years, 7 months ago by pmarch
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

This CL switches to new blink API (CL 257803006), the old API will be discarded afterwords. BUG=366916 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M extensions/renderer/dom_activity_logger.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pmarch
Hi Michael and Jeffrey This CL will go after https://codereview.chromium.org/257803006/ Please, review it when you ...
6 years, 7 months ago (2014-05-07 19:35:44 UTC) #1
Jeffrey Yasskin
lgtm
6 years, 7 months ago (2014-05-08 00:17:59 UTC) #2
mvrable
lgtm
6 years, 7 months ago (2014-05-08 04:34:38 UTC) #3
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 6 months ago (2014-06-03 15:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/271553006/1
6 years, 6 months ago (2014-06-03 15:56:31 UTC) #5
pmarch
The CQ bit was unchecked by pmarch@chromium.org
6 years, 6 months ago (2014-06-03 16:47:47 UTC) #6
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 6 months ago (2014-06-03 21:19:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/271553006/1
6 years, 6 months ago (2014-06-03 21:21:42 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 00:37:31 UTC) #9
Message was sent while issue was closed.
Change committed as 274687

Powered by Google App Engine
This is Rietveld 408576698