Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 271553004: Force composite compositing/ tests (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, danakj
Visibility:
Public.

Description

Force composite compositing/ tests BUG=361729, 371111 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173661

Patch Set 1 #

Patch Set 2 : TestExpectations #

Total comments: 2

Patch Set 3 : Set plugin tests to NeedsRebaseline #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
There were only a few failures in making the compositing/ directory force composited. (1) There ...
6 years, 7 months ago (2014-05-07 22:30:49 UTC) #1
ojan
lgtm https://codereview.chromium.org/271553004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/271553004/diff/20001/LayoutTests/TestExpectations#newcode47 LayoutTests/TestExpectations:47: crbug.com/371111 compositing/plugins/1x1-composited-plugin.html [ Pass Failure ] Lets just ...
6 years, 7 months ago (2014-05-07 23:30:22 UTC) #2
enne (OOO)
https://codereview.chromium.org/271553004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/271553004/diff/20001/LayoutTests/TestExpectations#newcode47 LayoutTests/TestExpectations:47: crbug.com/371111 compositing/plugins/1x1-composited-plugin.html [ Pass Failure ] On 2014/05/07 23:30:23, ...
6 years, 7 months ago (2014-05-07 23:35:50 UTC) #3
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-08 17:15:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/271553004/60001
6 years, 7 months ago (2014-05-08 17:17:17 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 18:39:09 UTC) #6
Message was sent while issue was closed.
Change committed as 173661

Powered by Google App Engine
This is Rietveld 408576698