[MD Bookmarks] Add import/export bookmarks HTML features

chrome/browser/resources/md_bookmarks/store.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var BookmarksStore = Polymer({
   is: 'bookmarks-store',
 
   properties: {
     /** @type {BookmarkTreeNode} */
     rootNode: {
@@ skipping 61 matching lines @@
    * Initializes the store with data from the bookmarks API.
    * Called by app on attached.
    */
   initializeStore: function() {
     chrome.bookmarks.getTree(function(results) {
       this.setupStore_(results[0]);
     }.bind(this));
     // Attach bookmarks API listeners.
     chrome.bookmarks.onRemoved.addListener(this.onBookmarkRemoved_.bind(this));
     chrome.bookmarks.onChanged.addListener(this.onBookmarkChanged_.bind(this));
+    chrome.bookmarks.onImportBegan.addListener(this.onImportBegan_.bind(this));
+    chrome.bookmarks.onImportEnded.addListener(this.onImportEnded_.bind(this));
   },
 
   //////////////////////////////////////////////////////////////////////////////
   // bookmarks-store, private:
 
   /**
    * @param {BookmarkTreeNode} rootNode
    * @private
    */
   setupStore_: function(rootNode) {
@@ skipping 227 matching lines @@
   onBookmarkChanged_: function(id, changeInfo) {
     if (changeInfo.title)
       this.set(this.idToNodeMap_[id].path + '.title', changeInfo.title);
     if (changeInfo.url)
       this.set(this.idToNodeMap_[id].path + '.url', changeInfo.url);
 
     if (this.searchTerm)
       this.updateSearchDisplay_();
   },
 
+  /**
+   * Called when importing bookmark is started.
+   */
+  onImportBegan_: function() {
+    chrome.bookmarks.onRemoved.removeListener(this.onBookmarkRemoved_.bind(this));

[tsergeant, 2017/02/24 00:03:18]

The docs for importBegan say:

"Expensive observers should ignore onCreated updates until onImportEnded is
fired"

(https://developer.chrome.com/extensions/bookmarks#event-onImportBegan)

We currently don't have an onCreated listener, and I don't think we need to
pause onRemoved/onChanged listeners during the import.

So, I think it's okay to leave this listener blank, with a TODO to pause
onCreated once that event is used.

[rongjie, 2017/02/24 00:20:46]

Done.

+    chrome.bookmarks.onChanged.removeListener(this.onBookmarkChanged_.bind(this));
+  },
+
+  /**
+   * Called when importing bookmark node is finished.
+   */
+  onImportEnded_: function() {
+    chrome.bookmarks.getTree(function(results) {
+      this.setupStore_(results[0]);

[tsergeant, 2017/02/24 00:03:18]

I think you need to call

this.updateSelectedDisplay_()

here to make the list update.

We're currently in the middle of rewriting the store to reduce the need to do
some of these things (see: https://codereview.chromium.org/2704983002/), so I'm
not too concerned if this doesn't work perfectly right now -- so long we
implement it right in the new system.

[rongjie, 2017/02/24 00:20:46]

Done.

+    }.bind(this));
+
+    chrome.bookmarks.onRemoved.addListener(this.onBookmarkRemoved_.bind(this));
+    chrome.bookmarks.onChanged.addListener(this.onBookmarkChanged_.bind(this));
+  },
+
   //////////////////////////////////////////////////////////////////////////////
   // bookmarks-store, bookmarks app event listeners:
 
   /**
    * @param {Event} e
    * @private
    */
   onSearchTermChanged_: function(e) {
     this.searchTerm = /** @type {string} */ (e.detail);
   },
@@ skipping 98 matching lines @@
     idToNodeMap[bookmarkNode.id] = bookmarkNode;
 
   if (bookmarkNode.url)
     return;
 
   bookmarkNode.isSelectedFolder = false;
   bookmarkNode.isOpen = true;
   for (var i = 0; i < bookmarkNode.children.length; i++)
     BookmarksStore.initNodes(bookmarkNode.children[i], idToNodeMap);
 };