Make FakeVideoCaptureDeviceFactory configurable to arbitrary fake device configurations

content/browser/webrtc/webrtc_depth_capture_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/webrtc/webrtc_content_browsertest_base.h"
@@ skipping 29 matching lines @@
                    return value.find(switch_string) != std::string::npos;
                  }),
              argv.end());
   command_line->InitFromArgv(argv);
 }
 
 }  // namespace
 
 namespace content {
 
+template <int device_count>
 class WebRtcDepthCaptureBrowserTest : public WebRtcContentBrowserTestBase {
  public:
   WebRtcDepthCaptureBrowserTest() {
     // Automatically grant device permission.
     AppendUseFakeUIForMediaStreamFlag();
   }
   ~WebRtcDepthCaptureBrowserTest() override {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
-    // Test using two video capture devices - a color and a 16-bit depth device.
     // By default, command line argument is present with no value.  We need to
     // remove it and then add the value defining two video capture devices.
     const std::string fake_device_switch =
         switches::kUseFakeDeviceForMediaStream;
     ASSERT_TRUE(command_line->HasSwitch(fake_device_switch) &&
                 command_line->GetSwitchValueASCII(fake_device_switch).empty());
     RemoveSwitchFromCommandLine(command_line, fake_device_switch);
-    command_line->AppendSwitchASCII(fake_device_switch, "device-count=2");
+    command_line->AppendSwitchASCII(
+        fake_device_switch,
+        base::StringPrintf("device-count=%d", device_count));
     WebRtcContentBrowserTestBase::SetUpCommandLine(command_line);
   }
 };
 
-IN_PROC_BROWSER_TEST_F(WebRtcDepthCaptureBrowserTest,
+// Test using two video capture devices - a color and a 16-bit depth device.
+using WebRtcTwoDeviceDepthCaptureBrowserTest = WebRtcDepthCaptureBrowserTest<2>;
+
+// Test using only a color device.
+using WebRtcOneDeviceDepthCaptureBrowserTest = WebRtcDepthCaptureBrowserTest<1>;
+
+IN_PROC_BROWSER_TEST_F(WebRtcTwoDeviceDepthCaptureBrowserTest,
                        GetDepthStreamAndCallCreateImageBitmap) {
   ASSERT_TRUE(embedded_test_server()->Start());
 
   GURL url(
       embedded_test_server()->GetURL("/media/getusermedia-depth-capture.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(base::StringPrintf(
       "%s({video: true});", kGetDepthStreamAndCallCreateImageBitmap));
 }
 
-IN_PROC_BROWSER_TEST_F(WebRtcDepthCaptureBrowserTest,
+IN_PROC_BROWSER_TEST_F(WebRtcTwoDeviceDepthCaptureBrowserTest,
                        GetDepthStreamAndCameraCalibration) {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   command_line->AppendSwitchASCII("--enable-blink-features",
                                   "MediaGetSettings,MediaCaptureDepth");
 
   ASSERT_TRUE(embedded_test_server()->Start());
 
   GURL url(
       embedded_test_server()->GetURL("/media/getusermedia-depth-capture.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(base::StringPrintf(
       "%s({video: true});", kGetDepthStreamAndCameraCalibration));
 }
 
-IN_PROC_BROWSER_TEST_F(WebRtcDepthCaptureBrowserTest,
+IN_PROC_BROWSER_TEST_F(WebRtcTwoDeviceDepthCaptureBrowserTest,
                        GetBothStreamsAndCheckForFeaturesPresence) {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   command_line->AppendSwitchASCII("--enable-blink-features",
                                   "MediaGetSettings,MediaCaptureDepth");
 
   ASSERT_TRUE(embedded_test_server()->Start());
 
   GURL url(
       embedded_test_server()->GetURL("/media/getusermedia-depth-capture.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(base::StringPrintf(
       "%s({video: true});", kGetBothStreamsAndCheckForFeaturesPresence));
 }
 
-IN_PROC_BROWSER_TEST_F(WebRtcDepthCaptureBrowserTest, GetStreamsByVideoKind) {
+IN_PROC_BROWSER_TEST_F(WebRtcTwoDeviceDepthCaptureBrowserTest,
+                       GetStreamsByVideoKind) {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   command_line->AppendSwitchASCII("--enable-blink-features",
                                   "MediaGetSettings,MediaCaptureDepth");
 
   ASSERT_TRUE(embedded_test_server()->Start());
 
   GURL url(
       embedded_test_server()->GetURL("/media/getusermedia-depth-capture.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(
       base::StringPrintf("%s({video: true});", kGetStreamsByVideoKind));
 }
 
-IN_PROC_BROWSER_TEST_F(WebRtcDepthCaptureBrowserTest,
+IN_PROC_BROWSER_TEST_F(WebRtcOneDeviceDepthCaptureBrowserTest,
                        GetStreamsByVideoKindNoDepth) {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  // Set fake factory to have only one device, of type "color".
-  RemoveSwitchFromCommandLine(command_line,
-                              switches::kUseFakeDeviceForMediaStream);
-  command_line->AppendSwitchASCII(switches::kUseFakeDeviceForMediaStream,
-                                  "device-count=1");
   command_line->AppendSwitchASCII("--enable-blink-features",
                                   "MediaGetSettings,MediaCaptureDepth");
 
   ASSERT_TRUE(embedded_test_server()->Start());
 
   GURL url(
       embedded_test_server()->GetURL("/media/getusermedia-depth-capture.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(
       base::StringPrintf("%s({video: true});", kGetStreamsByVideoKindNoDepth));
 }
 
 }  // namespace content