Make FakeVideoCaptureDeviceFactory configurable to arbitrary fake device configurations

media/capture/video/fake_video_capture_device_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/fake_video_capture_device.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 241 matching lines @@
 
   const VideoCaptureFormat& last_format() const { return last_format_; }
 
   VideoCaptureDeviceDescriptors descriptors_;
   const std::unique_ptr<base::MessageLoop> loop_;
   std::unique_ptr<base::RunLoop> run_loop_;
   std::unique_ptr<MockClient> client_;
   const scoped_refptr<DeviceEnumerationListener> device_enumeration_listener_;
   const scoped_refptr<ImageCaptureClient> image_capture_client_;
   VideoCaptureFormat last_format_;
-  const std::unique_ptr<VideoCaptureDeviceFactory>
+  const std::unique_ptr<FakeVideoCaptureDeviceFactory>
       video_capture_device_factory_;
 };
 
 class FakeVideoCaptureDeviceTest
     : public FakeVideoCaptureDeviceBase,
       public ::testing::WithParamInterface<
-          ::testing::tuple<FakeVideoCaptureDeviceMaker::PixelFormat,
-                           FakeVideoCaptureDeviceMaker::DeliveryMode,
+          ::testing::tuple<VideoPixelFormat,
+                           FakeVideoCaptureDevice::DeliveryMode,
                            float>> {};
 
 // Tests that a frame is delivered with the expected settings.
 // Sweeps through a fixed set of requested/expected resolutions.
 TEST_P(FakeVideoCaptureDeviceTest, CaptureUsing) {
   if (testing::get<1>(GetParam()) ==
-          FakeVideoCaptureDeviceMaker::DeliveryMode::
-              USE_CLIENT_PROVIDED_BUFFERS &&
-      testing::get<0>(GetParam()) ==
-          FakeVideoCaptureDeviceMaker::PixelFormat::MJPEG) {
+          FakeVideoCaptureDevice::DeliveryMode::USE_CLIENT_PROVIDED_BUFFERS &&
+      testing::get<0>(GetParam()) == media::PIXEL_FORMAT_MJPEG) {
     // Unsupported case
     return;
   }
 
   const std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors(
       EnumerateDevices());
   ASSERT_FALSE(descriptors->empty());
 
-  auto device = FakeVideoCaptureDeviceMaker::MakeInstance(
-      testing::get<0>(GetParam()), testing::get<1>(GetParam()),
-      testing::get<2>(GetParam()));
+  auto device =
+      FakeVideoCaptureDeviceFactory::CreateDeviceWithDefaultResolutions(
+          testing::get<0>(GetParam()), testing::get<1>(GetParam()),
+          testing::get<2>(GetParam()));
   ASSERT_TRUE(device);
 
   // First: Requested, Second: Expected
   std::vector<std::pair<gfx::Size, gfx::Size>> resolutions_to_test;
   resolutions_to_test.emplace_back(gfx::Size(640, 480), gfx::Size(640, 480));
   resolutions_to_test.emplace_back(gfx::Size(104, 105), gfx::Size(320, 240));
   resolutions_to_test.emplace_back(gfx::Size(0, 0), gfx::Size(96, 96));
   resolutions_to_test.emplace_back(gfx::Size(0, 720), gfx::Size(96, 96));
   resolutions_to_test.emplace_back(gfx::Size(1920, 1080),
                                    gfx::Size(1920, 1080));
 
   for (const auto& resolution : resolutions_to_test) {
     auto client = CreateClient();
     EXPECT_CALL(*client, OnError(_, _)).Times(0);
 
     VideoCaptureParams capture_params;
     capture_params.requested_format.frame_size = resolution.first;
     capture_params.requested_format.frame_rate = testing::get<2>(GetParam());
     device->AllocateAndStart(capture_params, std::move(client));
 
     WaitForCapturedFrame();
     EXPECT_EQ(resolution.second.width(), last_format().frame_size.width());
     EXPECT_EQ(resolution.second.height(), last_format().frame_size.height());
-    EXPECT_EQ(last_format().pixel_format,
-              static_cast<VideoPixelFormat>(testing::get<0>(GetParam())));
+    EXPECT_EQ(last_format().pixel_format, testing::get<0>(GetParam()));
     EXPECT_EQ(last_format().frame_rate, testing::get<2>(GetParam()));
     device->StopAndDeAllocate();
   }
 }
 
 INSTANTIATE_TEST_CASE_P(
     ,
     FakeVideoCaptureDeviceTest,
-    Combine(Values(FakeVideoCaptureDeviceMaker::PixelFormat::I420,
-                   FakeVideoCaptureDeviceMaker::PixelFormat::Y16,
-                   FakeVideoCaptureDeviceMaker::PixelFormat::MJPEG),
-            Values(FakeVideoCaptureDeviceMaker::DeliveryMode::
-                       USE_DEVICE_INTERNAL_BUFFERS,
-                   FakeVideoCaptureDeviceMaker::DeliveryMode::
-                       USE_CLIENT_PROVIDED_BUFFERS),
-            Values(20, 29.97, 30, 50, 60)));
+    Combine(
+        Values(PIXEL_FORMAT_I420, PIXEL_FORMAT_Y16, PIXEL_FORMAT_MJPEG),
+        Values(
+            FakeVideoCaptureDevice::DeliveryMode::USE_DEVICE_INTERNAL_BUFFERS,
+            FakeVideoCaptureDevice::DeliveryMode::USE_CLIENT_PROVIDED_BUFFERS),
+        Values(20, 29.97, 30, 50, 60)));
 
 TEST_F(FakeVideoCaptureDeviceTest, GetDeviceSupportedFormats) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kUseFakeDeviceForMediaStream, "device-count=4");
+  video_capture_device_factory_->SetToDefaultDevicesConfig(4);
   std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors(
       EnumerateDevices());
   ASSERT_EQ(4u, descriptors->size());
   const VideoPixelFormat expected_format_by_device_index[] = {
       PIXEL_FORMAT_I420, PIXEL_FORMAT_Y16, PIXEL_FORMAT_MJPEG,
       PIXEL_FORMAT_I420};
 
   int device_index = 0;
   for (const auto& descriptors_iterator : *descriptors) {
     VideoCaptureFormats supported_formats;
@@ skipping 20 matching lines @@
     EXPECT_GE(supported_formats[3].frame_rate, 20.0);
     EXPECT_EQ(1920, supported_formats[4].frame_size.width());
     EXPECT_EQ(1080, supported_formats[4].frame_size.height());
     EXPECT_EQ(expected_format, supported_formats[4].pixel_format);
     EXPECT_GE(supported_formats[4].frame_rate, 20.0);
     device_index++;
   }
 }
 
 TEST_F(FakeVideoCaptureDeviceTest, GetCameraCalibration) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kUseFakeDeviceForMediaStream, "device-count=2");
+  const size_t device_count = 2;
+  video_capture_device_factory_->SetToDefaultDevicesConfig(device_count);
   std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors(
       EnumerateDevices());
-  ASSERT_EQ(2u, descriptors->size());
+  ASSERT_EQ(device_count, descriptors->size());
   ASSERT_FALSE(descriptors->at(0).camera_calibration);
   const VideoCaptureDeviceDescriptor& depth_device = descriptors->at(1);
   EXPECT_EQ("/dev/video1", depth_device.device_id);
   ASSERT_TRUE(depth_device.camera_calibration);
   EXPECT_EQ(135.0, depth_device.camera_calibration->focal_length_x);
   EXPECT_EQ(135.6, depth_device.camera_calibration->focal_length_y);
   EXPECT_EQ(0.0, depth_device.camera_calibration->depth_near);
   EXPECT_EQ(65.535, depth_device.camera_calibration->depth_far);
 }
 
+TEST_F(FakeVideoCaptureDeviceTest, ErrorDeviceReportsError) {
+  auto device = FakeVideoCaptureDeviceFactory::CreateErrorDevice();
+  ASSERT_TRUE(device);
+  EXPECT_CALL(*client_, OnError(_, _));
+  VideoCaptureParams capture_params;
+  capture_params.requested_format.frame_size.SetSize(640, 480);
+  capture_params.requested_format.frame_rate = 30.0;
+  device->AllocateAndStart(capture_params, std::move(client_));
+}
+
 TEST_F(FakeVideoCaptureDeviceTest, GetAndSetCapabilities) {
-  auto device = FakeVideoCaptureDeviceMaker::MakeInstance(
-      FakeVideoCaptureDeviceMaker::PixelFormat::I420,
-      FakeVideoCaptureDeviceMaker::DeliveryMode::USE_DEVICE_INTERNAL_BUFFERS,
-      30.0);
+  auto device =
+      FakeVideoCaptureDeviceFactory::CreateDeviceWithDefaultResolutions(
+          PIXEL_FORMAT_I420,
+          FakeVideoCaptureDevice::DeliveryMode::USE_DEVICE_INTERNAL_BUFFERS,
+          30.0);
   ASSERT_TRUE(device);
 
   VideoCaptureParams capture_params;
   capture_params.requested_format.frame_size.SetSize(640, 480);
   capture_params.requested_format.frame_rate = 30.0;
   device->AllocateAndStart(capture_params, std::move(client_));
 
   VideoCaptureDevice::GetPhotoCapabilitiesCallback scoped_get_callback(
       base::Bind(&ImageCaptureClient::DoOnGetPhotoCapabilities,
                  image_capture_client_),
@@ skipping 87 matching lines @@
   device->GetPhotoCapabilities(std::move(scoped_get_callback2));
   run_loop_.reset(new base::RunLoop());
   run_loop_->Run();
   EXPECT_EQ(max_zoom_value,
             image_capture_client_->capabilities()->zoom->current);
 
   device->StopAndDeAllocate();
 }
 
 TEST_F(FakeVideoCaptureDeviceTest, TakePhoto) {
-  auto device = FakeVideoCaptureDeviceMaker::MakeInstance(
-      FakeVideoCaptureDeviceMaker::PixelFormat::I420,
-      FakeVideoCaptureDeviceMaker::DeliveryMode::USE_DEVICE_INTERNAL_BUFFERS,
-      30.0);
+  auto device =
+      FakeVideoCaptureDeviceFactory::CreateDeviceWithDefaultResolutions(
+          PIXEL_FORMAT_I420,
+          FakeVideoCaptureDevice::DeliveryMode::USE_DEVICE_INTERNAL_BUFFERS,
+          30.0);
   ASSERT_TRUE(device);
 
   VideoCaptureParams capture_params;
   capture_params.requested_format.frame_size.SetSize(640, 480);
   capture_params.requested_format.frame_rate = 30.0;
   device->AllocateAndStart(capture_params, std::move(client_));
 
   VideoCaptureDevice::TakePhotoCallback scoped_callback(
       base::Bind(&ImageCaptureClient::DoOnPhotoTaken, image_capture_client_),
       base::Bind(&ImageCaptureClient::OnTakePhotoFailure,
@@ skipping 11 matching lines @@
   std::string switch_value_string;
   float expected_fps;
   size_t expected_device_count;
   std::vector<VideoPixelFormat> expected_pixel_formats;
 };
 
 class FakeVideoCaptureDeviceFactoryTest
     : public FakeVideoCaptureDeviceBase,
       public ::testing::WithParamInterface<CommandLineTestData> {};
 
+TEST_F(FakeVideoCaptureDeviceFactoryTest, DeviceWithNoSupportedFormats) {
+  std::vector<FakeVideoCaptureDeviceSettings> config;
+  FakeVideoCaptureDeviceSettings device_setting;
+  device_setting.device_id = "Device with no supported formats";
+  config.emplace_back(device_setting);
+  video_capture_device_factory_->SetToCustomDevicesConfig(config);
+
+  const std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors(
+      EnumerateDevices());
+  EXPECT_EQ(1u, descriptors->size());
+  media::VideoCaptureFormats supported_formats;
+  video_capture_device_factory_->GetSupportedFormats(descriptors->at(0),
+                                                     &supported_formats);
+  EXPECT_EQ(0u, supported_formats.size());
+  auto device = video_capture_device_factory_->CreateDevice(descriptors->at(0));
+  EXPECT_TRUE(device.get());
+
+  auto client = CreateClient();
+  EXPECT_CALL(*client, OnError(_, _));
+  VideoCaptureParams capture_params;
+  capture_params.requested_format.frame_size.SetSize(1280, 720);
+  device->AllocateAndStart(capture_params, std::move(client));
+}
+
 // Tests that the FakeVideoCaptureDeviceFactory delivers the expected number
 // of devices and formats when being configured using command-line switches.
 TEST_P(FakeVideoCaptureDeviceFactoryTest, FrameRateAndDeviceCount) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kUseFakeDeviceForMediaStream, GetParam().switch_value_string);
+  std::vector<FakeVideoCaptureDeviceSettings> config;
+  FakeVideoCaptureDeviceFactory::ParseFakeDevicesConfigFromOptionsString(
+      GetParam().switch_value_string, &config);
+  video_capture_device_factory_->SetToCustomDevicesConfig(config);
+
   const std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors(
       EnumerateDevices());
   EXPECT_EQ(GetParam().expected_device_count, descriptors->size());
-  ASSERT_FALSE(descriptors->empty());
 
   int device_index = 0;
   for (const auto& descriptors_iterator : *descriptors) {
     media::VideoCaptureFormats supported_formats;
     video_capture_device_factory_->GetSupportedFormats(descriptors_iterator,
                                                        &supported_formats);
     for (const auto& supported_formats_entry : supported_formats) {
       EXPECT_EQ(GetParam().expected_pixel_formats[device_index],
                 supported_formats_entry.pixel_format);
     }
@@ skipping 41 matching lines @@
                                4u,
 
                                {PIXEL_FORMAT_I420, PIXEL_FORMAT_Y16,
                                 PIXEL_FORMAT_MJPEG, PIXEL_FORMAT_I420}},
            CommandLineTestData{"device-count=4,ownership=client",
                                20,
                                4u,
 
                                {PIXEL_FORMAT_I420, PIXEL_FORMAT_Y16,
                                 PIXEL_FORMAT_MJPEG, PIXEL_FORMAT_I420}},
-           CommandLineTestData{"device-count=0", 20, 1u, {PIXEL_FORMAT_I420}}));
+           CommandLineTestData{"device-count=0", 20, 0u, {PIXEL_FORMAT_I420}}));
 };  // namespace media