Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: net/http/http_auth_controller.h

Issue 2715513004: [net] Remove unnecessary virtual specifier (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_controller.h
diff --git a/net/http/http_auth_controller.h b/net/http/http_auth_controller.h
index dbc078e323a95339b14ca56b8ca1e64c5aa9cfa2..8de47198db156039ed6056e80ec13586ac8aca88 100644
--- a/net/http/http_auth_controller.h
+++ b/net/http/http_auth_controller.h
@@ -43,36 +43,35 @@ class NET_EXPORT_PRIVATE HttpAuthController
// value is a net error code. |OK| will be returned both in the case that
// a token is correctly generated synchronously, as well as when no tokens
// were necessary.
- virtual int MaybeGenerateAuthToken(const HttpRequestInfo* request,
- const CompletionCallback& callback,
- const NetLogWithSource& net_log);
+ int MaybeGenerateAuthToken(const HttpRequestInfo* request,
+ const CompletionCallback& callback,
+ const NetLogWithSource& net_log);
// Adds either the proxy auth header, or the origin server auth header,
// as specified by |target_|.
- virtual void AddAuthorizationHeader(
- HttpRequestHeaders* authorization_headers);
+ void AddAuthorizationHeader(HttpRequestHeaders* authorization_headers);
// Checks for and handles HTTP status code 401 or 407.
// |HandleAuthChallenge()| returns OK on success, or a network error code
// otherwise. It may also populate |auth_info_|.
- virtual int HandleAuthChallenge(scoped_refptr<HttpResponseHeaders> headers,
- const SSLInfo& ssl_info,
- bool do_not_send_server_auth,
- bool establishing_tunnel,
- const NetLogWithSource& net_log);
+ int HandleAuthChallenge(scoped_refptr<HttpResponseHeaders> headers,
+ const SSLInfo& ssl_info,
+ bool do_not_send_server_auth,
+ bool establishing_tunnel,
+ const NetLogWithSource& net_log);
// Store the supplied credentials and prepare to restart the auth.
- virtual void ResetAuth(const AuthCredentials& credentials);
+ void ResetAuth(const AuthCredentials& credentials);
- virtual bool HaveAuthHandler() const;
+ bool HaveAuthHandler() const;
- virtual bool HaveAuth() const;
+ bool HaveAuth() const;
- virtual scoped_refptr<AuthChallengeInfo> auth_info();
+ scoped_refptr<AuthChallengeInfo> auth_info();
- virtual bool IsAuthSchemeDisabled(HttpAuth::Scheme scheme) const;
- virtual void DisableAuthScheme(HttpAuth::Scheme scheme);
- virtual void DisableEmbeddedIdentity();
+ bool IsAuthSchemeDisabled(HttpAuth::Scheme scheme) const;
+ void DisableAuthScheme(HttpAuth::Scheme scheme);
+ void DisableEmbeddedIdentity();
private:
// Actions for InvalidateCurrentHandler()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698