mediaview: Support watchers in ArcDocumentsProviderRoot.

chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include <memory>
 #include <string>
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h"
 #include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h"
 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service_manager.h"
+#include "components/arc/common/file_system.mojom.h"
 #include "components/arc/test/fake_file_system_instance.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "storage/common/fileapi/directory_entry.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
+using ChangeType = arc::ArcDocumentsProviderRoot::ChangeType;
 using storage::DirectoryEntry;
 using Document = arc::FakeFileSystemInstance::Document;
 using EntryList = storage::AsyncFileUtil::EntryList;
 
 namespace arc {
 
 namespace {
 
 // Simliar as FakeFileSystemInstance::Document, but all fields are primitives
 // so that values can be constexpr.
@@ skipping 78 matching lines @@
       fake_file_system_.AddDocument(ToDocument(spec));
     }
 
     arc_service_manager_ = base::MakeUnique<ArcServiceManager>(nullptr);
     arc_service_manager_->AddService(
         ArcFileSystemOperationRunner::CreateForTesting(
             arc_service_manager_->arc_bridge_service()));
     arc_service_manager_->arc_bridge_service()->file_system()->SetInstance(
         &fake_file_system_);
 
+    // Run the message loop until FileSystemInstance::Init() is called.
+    base::RunLoop().RunUntilIdle();
+    ASSERT_TRUE(fake_file_system_.InitCalled());
+
     root_ = base::MakeUnique<ArcDocumentsProviderRoot>(kAuthority,
                                                        kRootSpec.document_id);
   }
 
  protected:
   content::TestBrowserThreadBundle thread_bundle_;
   FakeFileSystemInstance fake_file_system_;
   std::unique_ptr<ArcServiceManager> arc_service_manager_;
   std::unique_ptr<ArcDocumentsProviderRoot> root_;
 
@@ skipping 147 matching lines @@
             EXPECT_FALSE(file_list[2].is_directory);
             EXPECT_EQ(FILE_PATH_LITERAL("dup.mp4"), file_list[3].name);
             EXPECT_FALSE(file_list[3].is_directory);
             EXPECT_FALSE(has_more);
             run_loop->Quit();
           },
           &run_loop));
   run_loop.Run();
 }
 
+TEST_F(ArcDocumentsProviderRootTest, WatchChanged) {
+  int num_called = 0;
+  auto watcher_callback = base::Bind(
+      [](int* num_called, ChangeType type) {
+        EXPECT_EQ(ChangeType::CHANGED, type);
+        ++(*num_called);
+      },
+      &num_called);
+
+  {
+    base::RunLoop run_loop;
+    root_->AddWatcher(base::FilePath(FILE_PATH_LITERAL("dir")),
+                      watcher_callback,
+                      base::Bind(
+                          [](base::RunLoop* run_loop, base::File::Error error) {
+                            EXPECT_EQ(base::File::FILE_OK, error);
+                            run_loop->Quit();
+                          },
+                          &run_loop));
+    run_loop.Run();
+  }
+
+  EXPECT_EQ(0, num_called);
+  fake_file_system_.TriggerWatchers(kAuthority, kDirSpec.document_id,
+                                    mojom::ChangeType::CHANGED);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(1, num_called);
+
+  {
+    base::RunLoop run_loop;
+    root_->RemoveWatcher(
+        base::FilePath(FILE_PATH_LITERAL("dir")),
+        base::Bind(
+            [](base::RunLoop* run_loop, base::File::Error error) {
+              EXPECT_EQ(base::File::FILE_OK, error);
+              run_loop->Quit();
+            },
+            &run_loop));
+    run_loop.Run();
+  }
+}
+
+TEST_F(ArcDocumentsProviderRootTest, WatchDeleted) {
+  int num_called = 0;
+  auto watcher_callback = base::Bind(
+      [](int* num_called, ChangeType type) {
+        EXPECT_EQ(ChangeType::DELETED, type);
+        ++(*num_called);
+      },
+      &num_called);
+
+  {
+    base::RunLoop run_loop;
+    root_->AddWatcher(base::FilePath(FILE_PATH_LITERAL("dir")),
+                      watcher_callback,
+                      base::Bind(
+                          [](base::RunLoop* run_loop, base::File::Error error) {
+                            EXPECT_EQ(base::File::FILE_OK, error);
+                            run_loop->Quit();
+                          },
+                          &run_loop));
+    run_loop.Run();
+  }
+
+  EXPECT_EQ(0, num_called);
+  fake_file_system_.TriggerWatchers(kAuthority, kDirSpec.document_id,
+                                    mojom::ChangeType::CHANGED);

[hidehiko, 2017/02/23 12:10:54]

DELETED?

[Shuhei Takahashi, 2017/03/02 07:06:01]

Ugh, I somehow failed to run unit tests for this CL. Sorry about that.

+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(1, num_called);
+
+  // The watcher has already been deleted, so RemoveWatcher() should fail.
+  {
+    base::RunLoop run_loop;
+    root_->RemoveWatcher(
+        base::FilePath(FILE_PATH_LITERAL("dir")),
+        base::Bind(
+            [](base::RunLoop* run_loop, base::File::Error error) {
+              EXPECT_EQ(base::File::FILE_ERROR_FAILED, error);
+              run_loop->Quit();
+            },
+            &run_loop));
+    run_loop.Run();
+  }
+}
+
 TEST_F(ArcDocumentsProviderRootTest, ResolveToContentUrl) {
   base::RunLoop run_loop;
   root_->ResolveToContentUrl(
       base::FilePath(FILE_PATH_LITERAL("dir/photo.jpg")),
       base::Bind(
           [](base::RunLoop* run_loop, const GURL& url) {
             EXPECT_EQ(GURL("content://org.chromium.test/document/photo-id"),
                       url);
             run_loop->Quit();
           },
@@ skipping 37 matching lines @@
           [](base::RunLoop* run_loop, const GURL& url) {
             EXPECT_EQ(GURL("content://org.chromium.test/document/dup3-id"),
                       url);
             run_loop->Quit();
           },
           &run_loop));
   run_loop.Run();
 }
 
 }  // namespace arc