Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: ash/common/system/tray/label_tray_view.h

Issue 2715463004: Remove non-MD code from LabelTrayView (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/label_tray_view.h
diff --git a/ash/common/system/tray/label_tray_view.h b/ash/common/system/tray/label_tray_view.h
index f0781cbe452065660b7c08dc36f69fe423284ec0..cf480fd1b8dd45c07e6bc175765fd6192705e70d 100644
--- a/ash/common/system/tray/label_tray_view.h
+++ b/ash/common/system/tray/label_tray_view.h
@@ -9,16 +9,19 @@
#include "base/strings/string16.h"
#include "ui/views/view.h"
-namespace ash {
+namespace gfx {
+struct VectorIcon;
+} // namespace gfx
+namespace ash {
class ViewClickListener;
-// View for simple information in tray. Automatically hides when message is
-// empty. Supports multiline messages.
-
+// A view to display an icon and message text in the system menu which
+// automatically hides when the message text is empty. Multi-line
Evan Stade 2017/02/22 21:43:46 seems like this comment is wrapped early
tdanderson 2017/03/30 14:51:39 Done.
+// message text is supported.
class LabelTrayView : public views::View {
public:
- LabelTrayView(ViewClickListener* click_listener, int icon_resource_id);
+ LabelTrayView(ViewClickListener* click_listener, const gfx::VectorIcon& icon);
~LabelTrayView() override;
void SetMessage(const base::string16& message);
@@ -26,7 +29,7 @@ class LabelTrayView : public views::View {
views::View* CreateChildView(const base::string16& message) const;
ViewClickListener* click_listener_;
- int icon_resource_id_;
+ const gfx::VectorIcon& icon_;
base::string16 message_;
DISALLOW_COPY_AND_ASSIGN(LabelTrayView);

Powered by Google App Engine
This is Rietveld 408576698