Add option to gen_snapshot for creating a Makefile describing a snapshot's dependencies.

Add an option to gen_snapshot for creating a Makefile describing a snapshot's dependencies.  This option may be used when generating any snapshot kind, or without generating a snapshot.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/781fd36086de3440e7868d8cf1845300e960452e

[rmacnak, 2017-02-22 21:34:03]

Description was changed from

==========
Add option to gen_snapshot for creating a Makefile describing a snapshot's
dependencies.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.
==========

to

==========
Add an option to gen_snapshot for creating a Makefile describing a snapshot's
dependencies.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.
==========

[rmacnak, 2017-02-22 21:34:37]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-02-22 23:37:16]

lgtm with comments.

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc...
runtime/bin/file_android.cc:141: }
This seems to be identical in all the different OS versions, why not implement
this in file.cc, we already have some File:: functions over there.

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:528: Dart_Handle uri =
Dart_NewStringFromCString(uri_string);
ASSERT(!Dart_IsError(uri));

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/loader.cc#newco...
runtime/bin/loader.cc:600: return Dart_Null();
It looks like the core of this function can be factored out into a helper method
Loader::SendAndProcessReply(intptr_t request_kind, Dart_Handle url, uint8_t*
payload, intptr_t* payload_length);

and call it here
as
  SendAndProcessReply(Dart_kScriptTag, url, payload, payload_length);

or
  SendAndProcessReply(_Dart_kResolveAsFilePath, url, payload, payload_length);

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/allocation.h
File runtime/platform/allocation.h (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/allocation...
runtime/platform/allocation.h:1: // Copyright (c) 2013, the Dart project
authors.  Please see the AUTHORS file
2017

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/growable_a...
File runtime/platform/growable_array.h (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/growable_a...
runtime/platform/growable_array.h:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
2017

[rmacnak, 2017-02-23 19:00:18]

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc...
runtime/bin/file_android.cc:141: }
On 2017/02/22 23:37:16, siva wrote:
> This seems to be identical in all the different OS versions, why not implement
> this in file.cc, we already have some File:: functions over there.

Windows is different from non-Windows because of vsnprintf.

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:528: Dart_Handle uri =
Dart_NewStringFromCString(uri_string);
On 2017/02/22 23:37:16, siva wrote:
> ASSERT(!Dart_IsError(uri));

Done.

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/bin/loader.cc#newco...
runtime/bin/loader.cc:600: return Dart_Null();
On 2017/02/22 23:37:16, siva wrote:
> It looks like the core of this function can be factored out into a helper
method
> Loader::SendAndProcessReply(intptr_t request_kind, Dart_Handle url, uint8_t*
> payload, intptr_t* payload_length);
> 
> and call it here
> as
>   SendAndProcessReply(Dart_kScriptTag, url, payload, payload_length);
> 
> or
>   SendAndProcessReply(_Dart_kResolveAsFilePath, url, payload, payload_length);

Done.

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/allocation.h
File runtime/platform/allocation.h (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/allocation...
runtime/platform/allocation.h:1: // Copyright (c) 2013, the Dart project
authors.  Please see the AUTHORS file
On 2017/02/22 23:37:16, siva wrote:
> 2017

Done.

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/growable_a...
File runtime/platform/growable_array.h (right):

https://codereview.chromium.org/2715463003/diff/1/runtime/platform/growable_a...
runtime/platform/growable_array.h:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
On 2017/02/22 23:37:16, siva wrote:
> 2017

Done.

[Cutch, 2017-02-23 19:09:57]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-02-23 19:09:58]

DBC

https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:572: // TODO(28863) The use of tags that aren't declared
in dart_api.h's enum
I don't understand the issue here? These tags are being sent to the loader
isolate and not to the tag handler.

[Cutch, 2017-02-23 19:13:20]

Also,

sky_snapshot also has the flag '--print-deps' which needs to be supported as
well.  '--print-deps' is supposed to be very fast way of determining the
transitive set of files and I'm worried about the performance hit with
--print-deps in gen_snapshot. Currently sky_snapshot uses a dumb synchronous
loader and doesn't spin up another isolate to do the work.

[rmacnak, 2017-02-23 19:27:41]

https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:572: // TODO(28863) The use of tags that aren't declared
in dart_api.h's enum
On 2017/02/23 19:09:58, Cutch wrote:
> I don't understand the issue here? These tags are being sent to the loader
> isolate and not to the tag handler.

The cast here invokes undefined behavior because _Dart_kResolveAsFilePath is not
the value of any member of Dart_LibraryTag.

Making another attempt, I've managed to update several uses of Dart_LibraryTag
here to intptr_t without upsetting the signature of the actual tag handler. But
more changes are probably required here to get a clean UBSan build.

[rmacnak, 2017-02-23 20:34:22]

Description was changed from

==========
Add an option to gen_snapshot for creating a Makefile describing a snapshot's
dependencies.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.
==========

to

==========
Add an option to gen_snapshot for creating a Makefile describing a snapshot's
dependencies.  This option may be used when generating any snapshot kind, or
without generating a snapshot.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.
==========

[rmacnak, 2017-02-23 20:40:53]

Description was changed from

==========
Add an option to gen_snapshot for creating a Makefile describing a snapshot's
dependencies.  This option may be used when generating any snapshot kind, or
without generating a snapshot.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.
==========

to

==========
Add an option to gen_snapshot for creating a Makefile describing a snapshot's
dependencies.  This option may be used when generating any snapshot kind, or
without generating a snapshot.

 - Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/781fd36086de3440e7868d8cf1845300e960452e
==========

[rmacnak, 2017-02-23 20:40:54]

Committed patchset #3 (id:40001) manually as
781fd36086de3440e7868d8cf1845300e960452e (presubmit successful).