Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2715463003: Add option to gen_snapshot for creating a Makefile describing a snapshot's dependencies. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org, goderbauer
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an option to gen_snapshot for creating a Makefile describing a snapshot's dependencies. This option may be used when generating any snapshot kind, or without generating a snapshot. - Factor out MallocGrowableArray from vm to platform. - Add File::Print. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/781fd36086de3440e7868d8cf1845300e960452e

Patch Set 1 #

Total comments: 10

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -342 lines) Patch
M runtime/bin/file.h View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 21 chunks +153 lines, -16 lines 0 comments Download
M runtime/bin/isolate_data.h View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/bin/isolate_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/loader.h View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M runtime/bin/loader.cc View 1 2 6 chunks +24 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/loader.dart View 2 chunks +33 lines, -0 lines 0 comments Download
A runtime/platform/allocation.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A + runtime/platform/growable_array.h View 1 5 chunks +7 lines, -89 lines 0 comments Download
M runtime/platform/platform_headers.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/allocation.h View 3 chunks +1 line, -24 lines 0 comments Download
M runtime/vm/dart_api_state.h View 1 chunk +7 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/growable_array.h View 2 chunks +12 lines, -195 lines 0 comments Download
M runtime/vm/isolate_reload.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/timeline_analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/visitor.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rmacnak
3 years, 10 months ago (2017-02-22 21:34:38 UTC) #3
siva
lgtm with comments. https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc#newcode141 runtime/bin/file_android.cc:141: } This seems to be identical ...
3 years, 10 months ago (2017-02-22 23:37:16 UTC) #4
rmacnak
https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/2715463003/diff/1/runtime/bin/file_android.cc#newcode141 runtime/bin/file_android.cc:141: } On 2017/02/22 23:37:16, siva wrote: > This seems ...
3 years, 10 months ago (2017-02-23 19:00:18 UTC) #5
Cutch
DBC https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc File runtime/bin/loader.cc (right): https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc#newcode572 runtime/bin/loader.cc:572: // TODO(28863) The use of tags that aren't ...
3 years, 10 months ago (2017-02-23 19:09:58 UTC) #7
Cutch
Also, sky_snapshot also has the flag '--print-deps' which needs to be supported as well. '--print-deps' ...
3 years, 10 months ago (2017-02-23 19:13:20 UTC) #8
rmacnak
https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc File runtime/bin/loader.cc (right): https://codereview.chromium.org/2715463003/diff/20001/runtime/bin/loader.cc#newcode572 runtime/bin/loader.cc:572: // TODO(28863) The use of tags that aren't declared ...
3 years, 10 months ago (2017-02-23 19:27:41 UTC) #9
rmacnak
3 years, 10 months ago (2017-02-23 20:40:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
781fd36086de3440e7868d8cf1845300e960452e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698