Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/FadingBackgroundView.java

Issue 2715433008: 🏡 Add a ChromeHomeNewTabPage (Closed)
Patch Set: Changes from mdjones@ review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/FadingBackgroundView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/FadingBackgroundView.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/FadingBackgroundView.java
index 3d59bee0f10f275f9d81245f45862d816f6aba21..e8c5c69a31a2b632ec952fa4b5de00453b0ede75 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/FadingBackgroundView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/FadingBackgroundView.java
@@ -65,7 +65,7 @@ public class FadingBackgroundView extends View implements View.OnClickListener,
* @param alpha The desired alpha for this view.
*/
public void setViewAlpha(float alpha) {
- if (MathUtils.areFloatsEqual(alpha, getAlpha())) return;
+ if (!isEnabled() || MathUtils.areFloatsEqual(alpha, getAlpha())) return;
dgn 2017/02/28 14:09:56 Document the class to say what enabling or disabli
Theresa 2017/02/28 17:02:23 No, clicks don't still close the bottom sheet. The
dgn 2017/02/28 17:21:23 Ah thanks, missed that.
setAlpha(alpha);

Powered by Google App Engine
This is Rietveld 408576698